[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch for KTeaTime
From:       "David Jarvie" <lists () astrojar ! org ! uk>
Date:       2007-08-22 9:17:36
Message-ID: 62918.S0VKQUNDQxA=.1187774256.squirrel () www ! sensical ! net
[Download RAW message or body]

On Wednesday 22 August 2007 8:37, Daniel Teske wrote:
> Hi Stefan,
>
>>+SettingsDialog::SettingsDialog(TopLevel *toplevel, QList<Tea> &teas):
>> KDialog()
>>+{
>>+    this->toplevel=toplevel;
>
> In genetal name your member variables with an m_ prefix. And use a
> initialization list whereever possible.

Use (or not) of a prefix for member variables is a matter of personal
preference. It's useful when reading the code, but not obligatory.

> E.g. change:
> +SettingsDialog::SettingsDialog(TopLevel *toplevel, QList<Tea> &teas):
> KDialog()
> +{
> +    this->toplevel=toplevel;
>
> to
> SettingsDialog::SettingsDialog(TopLevel *toplevel, QList<Tea> &teas)
>  : KDialog(), m_toplevel(toplevel)
> {
>
> There is a line which is ~200 chars wide. I'm pretty sure most people
> break their lines earlier.
>
> We have a coding standard, but otherwise the formating is pretty much
> already as it should be.

The coding standard applies to KDE libraries only. Application authors are
free to choose their own coding standard.

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]