[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] better Imagemap Error recovery
From:       Luciano Montanaro <mikelima () virgilio ! it>
Date:       2002-06-13 7:41:34
[Download RAW message or body]

On Wednesday 12 June 2002 21:57, Dirk Mueller wrote:
> On Mit, 12 Jun 2002, Luciano Montanaro wrote:
> > Well, not for the case at hand, and for the patch submitted.
> > Only, umh, 'underdefined' coords matter here.
>
> Well, in order to understand the patch, I need to know why you disabled the
> current "fallback" else-case, which defines an image-wide area.
>
> My guess was that the image-wide area is the fall-back when no shape is
> given, because your case is about a given shape but not enough coordinates.
>
> Otherwise it can be integrated by changing the first if() that checks for
> the number of coordinates when shape==rect is given.
>

The problem with the current code is that if the if() chain that checks for 
Circles, polygons and rectangles fail, you get an image wide area.
But, I think that if a shape is given, and not enough coordinates are given,
a safer bet would be to return the empty QRegion. I'll look at the code again,
and send the corresponding patch in a short time.

Luciano
>
> Dirk
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]