[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: New cmake warning.
From:       Méven <meven29 () gmail ! com>
Date:       2022-05-03 16:43:48
Message-ID: CAOvFf8OYfEjyN1+fJbvhsL42GbhVMM8K=Zw9W1p0pWNo7Po4Bg () mail ! gmail ! com
[Download RAW message or body]

Le mar. 3 mai 2022 Ã  18:25, Thomas Friedrichsmeier <
thomas.friedrichsmeier@kdemail.net> a écrit :

> On Tue, 3 May 2022 10:35:20 +0200
> Méven <meven29@gmail.com> wrote:
>
> > I am guessing you are using cmake >= 3.16 so it allows you to run, but
> > since the project does not have a cmake minimum, for others using
> > cmake < 3.16 the build will break.
> > This warning highlights it, so you inform your contributor they need
> > cmake 3.16 before running into the hard fail in FindKF5.
>
> On the downside, project wishing to remain backwards-compatible with
> older systems (which will come with older versions of both cmake and
> ECM) will want to avoid adding such a requirement, explicitly.
>

Cmake 3.16 dates from November 2019 to put things in perspective.

-- 
Méven

[Attachment #3 (text/html)]

<div dir="ltr"><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le \
mar. 3 mai 2022 Ã   18:25, Thomas Friedrichsmeier &lt;<a \
href="mailto:thomas.friedrichsmeier@kdemail.net">thomas.friedrichsmeier@kdemail.net</a>&gt; \
a écrit  :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, 3 May 2022 \
10:35:20 +0200<br> Méven &lt;<a href="mailto:meven29@gmail.com" \
target="_blank">meven29@gmail.com</a>&gt; wrote:<br> <br>
&gt; I am guessing you are using cmake &gt;= 3.16 so it allows you to run, but<br>
&gt; since the project does not have a cmake minimum, for others using<br>
&gt; cmake &lt; 3.16 the build will break.<br>
&gt; This warning highlights it, so you inform your contributor they need<br>
&gt; cmake 3.16 before running into the hard fail in FindKF5.<br>
<br>
On the downside, project wishing to remain backwards-compatible with<br>
older systems (which will come with older versions of both cmake and<br>
ECM) will want to avoid adding such a requirement, explicitly.<br>
</blockquote></div></div><div><br></div><div></div><div>Cmake 3.16 dates from \
November 2019 to put things in perspective.</div><div><br></div><div>-- <br><div \
dir="ltr" class="gmail_signature">Méven</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]