[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122556: Bump Qt version to 5.4
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2015-02-13 20:56:28
Message-ID: 20150213205628.9050.40685 () probe ! kde ! org
[Download RAW message or body]
--===============4367539837524530405==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 13, 2015, 8:41 a.m., Martin Gräßlin wrote:
> > AFAIK our CI system doesn't support Qt 5.4 yet. I think we should first ensure \
> > the CI system is prepared for building with the new dependency.
>
> Albert Astals Cid wrote:
> It does
> http://build.kde.org/job/kde-baseapps_master_qt5/238/consoleFull
> ==== qt5 - Branch 5.4.1
>
> Kevin Funk wrote:
> Are we sure we want to depend on 5.4 just yet for such a central part of the KDE \
> workspace? I don't know the policies, but I'm curious.
> Qt 5.4 is not even available on Kubuntu Vivid 15.04 yet.
>
> Aleix Pol Gonzalez wrote:
> Plasma 5.2 recommends Qt 5.4 already, if it wasn't because of the build.kde.org \
> issue, I'd say it would be requiring 5.4.
> +1 to raising the dependency version.
As Albert mentioned above, the CI system already provides Qt 5.4.1.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122556/#review75971
-----------------------------------------------------------
On Feb. 13, 2015, 8:06 a.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122556/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2015, 8:06 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions \
> options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or do what \
> kompare [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45)
>
>
> Diffs
> -----
>
> CMakeLists.txt 6df9015
>
> Diff: https://git.reviewboard.kde.org/r/122556/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
--===============4367539837524530405==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122556/">https://git.reviewboard.kde.org/r/122556/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 13th, 2015, 8:41 a.m. UTC, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">AFAIK our CI system doesn't support Qt 5.4 yet. I \
think we should first ensure the CI system is prepared for building with the new \
dependency.</p></pre> </blockquote>
<p>On February 13th, 2015, 8:46 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
does http://build.kde.org/job/kde-baseapps_master_qt5/238/consoleFull
==== qt5 - Branch 5.4.1</p></pre>
</blockquote>
<p>On February 13th, 2015, 8:56 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are \
we sure we want to depend on 5.4 just yet for such a central part of the KDE \
workspace? I don't know the policies, but I'm curious.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt \
5.4 is not even available on Kubuntu Vivid 15.04 yet.</p></pre> </blockquote>
<p>On February 13th, 2015, 11:51 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Plasma 5.2 recommends Qt 5.4 already, if it wasn't because of the \
build.kde.org issue, I'd say it would be requiring 5.4.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 to \
raising the dependency version.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
Albert mentioned above, the CI system already provides Qt 5.4.1.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On February 13th, 2015, 8:06 a.m. UTC, Arjun AK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Arjun AK.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2015, 8:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions \
options)</code> seems to be Qt 5.4+. We either need to bump requirement to 5.4 or do \
what kompare <a href="https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">did</a></p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6df9015)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122556/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4367539837524530405==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic