[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed p
From: "Lamarque Souza" <lamarque () kde ! org>
Date: 2014-03-30 11:23:22
Message-ID: 20140330112322.20888.88175 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117175/#review54584
-----------------------------------------------------------
Hi, there is an error when trying to show the patch on reviewboard. Can you provide \
the correct patch?
I looked into the raw patch and I think the "return 1" line that you commented should \
be kept when the action is not upgrade.
- Lamarque Souza
On March 30, 2014, 3:47 a.m., Andrei Amuraritei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117175/
> -----------------------------------------------------------
>
> (Updated March 30, 2014, 3:47 a.m.)
>
>
> Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian Monroe, and \
> Lamarque Souza.
>
> Bugs: 306279 and 325028
> http://bugs.kde.org/show_bug.cgi?id=306279
> http://bugs.kde.org/show_bug.cgi?id=325028
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> When installing a new .comic provider from GHNS, it doesn't appear in the installed \
> list on the comic widget. This fixes it.
>
>
> Diffs
> -----
>
> plasma/tools/plasmapkg/main.cpp 61492fe
>
> Diff: https://git.reviewboard.kde.org/r/117175/diff/
>
>
> Testing
> -------
>
> Compile, add new comic widget, install new comic providers.
>
>
> Thanks,
>
> Andrei Amuraritei
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117175/">https://git.reviewboard.kde.org/r/117175/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, there is an error \
when trying to show the patch on reviewboard. Can you provide the correct patch?
I looked into the raw patch and I think the "return 1" line that you \
commented should be kept when the action is not upgrade.</pre> <br />
<p>- Lamarque Souza</p>
<br />
<p>On March 30th, 2014, 3:47 a.m. UTC, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian Monroe, \
and Lamarque Souza.</div> <div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated March 30, 2014, 3:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306279">306279</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=325028">325028</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When installing a new .comic provider from GHNS, it doesn't appear \
in the installed list on the comic widget. This fixes it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compile, add new comic widget, install new comic providers.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/tools/plasmapkg/main.cpp <span style="color: grey">(61492fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117175/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic