[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 115689: Fix khtml/ecma/xmlhttprequest.cpp to properly handle HEAD requests
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2014-02-12 7:20:55
Message-ID: 20140212072055.7585.8783 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115689/#review49621
-----------------------------------------------------------
no diff?
- Bernd Buschinski
On Feb. 12, 2014, 4:29 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115689/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 4:29 a.m.)
>
>
> Review request for kdelibs and Andrea Iacovitti.
>
>
> Bugs: 331007
> http://bugs.kde.org/show_bug.cgi?id=331007
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Fix khtml/ecma/xmlttprequest.cpp such that it correctly handles HEAD requests \
> without a noticable delay, i.e. use KIO::mimeType instead of KIO::get. Otherwise, \
> the request will wait for the content which is not returned when doing a stat \
> operation like HEAD.
>
> Diffs
> -----
>
>
> Diff: https://git.reviewboard.kde.org/r/115689/diff/
>
>
> Testing
> -------
>
> Tested HEAD redirection with http://greenbytes.de/tech/tc/httpredirects/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115689/">https://git.reviewboard.kde.org/r/115689/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no diff?</pre> <br />
<p>- Bernd Buschinski</p>
<br />
<p>On February 12th, 2014, 4:29 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Andrea Iacovitti.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2014, 4:29 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331007">331007</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix khtml/ecma/xmlttprequest.cpp such that it correctly handles HEAD \
requests without a noticable delay, i.e. use KIO::mimeType instead of KIO::get. \
Otherwise, the request will wait for the content which is not returned when doing a \
stat operation like HEAD.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested HEAD redirection with \
http://greenbytes.de/tech/tc/httpredirects/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115689/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic