[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving KFIleMetadata into KDE SC
From:       Vishesh Handa <me () vhanda ! in>
Date:       2014-01-23 10:20:54
Message-ID: 1921279.TFUaRpuVYV () vlap
[Download RAW message or body]

On Wednesday 22 January 2014 19:15:01 Àlex Fiestas wrote:
> · I would add the url and mimetype in the cto, plugins should not be able to
> change it anyway.

Fixed

> · Documentation needs improvement, specially ExtractionResult (making it
> clear that you should inherit it in order to use the lib).

Fixed.

> · ExtratorPlugin::mimetypes is pure virtual yet it has an implementation

Fixed.

> · Add context to i18n in typeinfo

Fixed

> Also you might want to use Qt translation libs so kfilemetadata becomes a Qt
> only lib, that might help other desktops/apps to use it (in kf5 you can use
> k18n if you want).

Sticking with i18n for now.

> 
> Once this is fix, yo get +1 from me !

Thanks

-- 
Vishesh Handa
[prev in list] [next in list] [prev in thread] [next in thread]