[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 114481: khtml/ecma: Implement canvas2d font, measureText and a basic fillText
From:       "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date:       2013-12-15 17:11:01
Message-ID: 20131215171101.12482.31923 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114481/
-----------------------------------------------------------

Review request for kdelibs.


Repository: kdelibs


Description
-------

khtml/ecma: Implement canvas2d font, measureText and a basic fillText

While font and measureText are complet, filltext is really just a bare basic implementation.
But still, thats what is used the most and it does draw Text :)


Diffs
-----

  khtml/ecma/kjs_context2d.h 481404e 
  khtml/ecma/kjs_context2d.cpp bbdba8f 
  khtml/html/html_canvasimpl.h e46ed8f 
  khtml/html/html_canvasimpl.cpp 53e0f22 

Diff: http://git.reviewboard.kde.org/r/114481/diff/


Testing
-------

Passes all font/measureText/fillText canvas tests on http://philip.html5.org/tests/canvas/suite/tests/
(for what we support for now, which (again) is just a bare basic for fillText)


Thanks,

Bernd Buschinski


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114481/">http://git.reviewboard.kde.org/r/114481/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">khtml/ecma: Implement canvas2d font, measureText and a basic fillText

While font and measureText are complet, filltext is really just a bare basic \
implementation. But still, thats what is used the most and it does draw Text :)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Passes all font/measureText/fillText canvas tests on \
http://philip.html5.org/tests/canvas/suite/tests/ (for what we support for now, which \
(again) is just a bare basic for fillText)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>khtml/ecma/kjs_context2d.h <span style="color: grey">(481404e)</span></li>

 <li>khtml/ecma/kjs_context2d.cpp <span style="color: grey">(bbdba8f)</span></li>

 <li>khtml/html/html_canvasimpl.h <span style="color: grey">(e46ed8f)</span></li>

 <li>khtml/html/html_canvasimpl.cpp <span style="color: grey">(53e0f22)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114481/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic