[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 107716: Fix generating kconfig skeletons with UrlList fields that have a default
From: "Chuso Perez" <kde () chuso ! net>
Date: 2013-03-03 19:21:22
Message-ID: 20130303192122.13802.9860 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107716/#review28492
-----------------------------------------------------------
I'm getting the same error with an Url property.
Can you please include the same fix for Url properties?
- Chuso Perez
On Dec. 14, 2012, 1:17 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107716/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2012, 1:17 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> This patch changes the generated code so that if a property is "UrlList" in the \
> kcfg file, the variable that will receive it when generating the skeleton is a \
> KUrl::List instead a QStringList. This solves the following compiling error:
> aleix@kubuntu:~/projects/muon/build$ make
> [ 0%] Built target muonprivate_automoc
> [ 0%] Building CXX object libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o
> In file included from /usr/include/kcoreconfigskeleton.h:28:0,
> from /usr/include/kconfigskeleton.h:28,
> from /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8,
> from /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4:
> /usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()':
> /usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const' is private
> /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: within \
> this context
>
> Diffs
> -----
>
> kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30
>
> Diff: http://git.reviewboard.kde.org/r/107716/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107716/">http://git.reviewboard.kde.org/r/107716/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm getting the same \
error with an Url property. Can you please include the same fix for Url \
properties?</pre> <br />
<p>- Chuso</p>
<br />
<p>On December 14th, 2012, 1:17 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2012, 1:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the generated code so that if a property is \
"UrlList" in the kcfg file, the variable that will receive it when \
generating the skeleton is a KUrl::List instead a QStringList. This solves the \
following compiling error:
aleix@kubuntu:~/projects/muon/build$ make
[ 0%] Built target muonprivate_automoc
[ 0%] Building CXX object libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o
In file included from /usr/include/kcoreconfigskeleton.h:28:0,
from /usr/include/kconfigskeleton.h:28,
from /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8,
from /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4:
/usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()':
/usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const' is private
/home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: within \
this context </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/kconfig_compiler/kconfig_compiler.cpp <span style="color: \
grey">(4203d30)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107716/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic