[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108928: khtml/xml: if the content-type is null don't override mimeType and contin
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2013-02-12 21:46:20
Message-ID: 20130212214620.4317.24123 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108928/
-----------------------------------------------------------
(Updated Feb. 12, 2013, 9:46 p.m.)
Review request for kdelibs.
Description (updated)
-------
khtml/xml: if the content-type is null don't override mimeType and continue parsing \
the responseXML
In case the server does not set the content-type, the \
getResponseHeader("Content-Type",dummy); function will return jsNull, which is \
correct. As null is also valid, don't override the mimeType and leave it as \
"text/xml", so we actually do parse the reponse.
Confirmed by
http://www.w3.org/TR/XMLHttpRequest/#document-response-entity-body
"If final MIME type is not null, text/html, text/xml, application/xml, or does not \
end in +xml, return null and terminate these steps." ~~
means, if it is one of these above -> continue
Diffs
-----
khtml/ecma/xmlhttprequest.cpp cd72fe8
Diff: http://git.reviewboard.kde.org/r/108928/diff/
Testing
-------
Thanks,
Bernd Buschinski
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108928/">http://git.reviewboard.kde.org/r/108928/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2013, 9:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">khtml/xml: if the content-type is null don't override mimeType and \
continue parsing the responseXML
In case the server does not set the content-type, the \
getResponseHeader("Content-Type",dummy); function will return jsNull, which \
is correct. As null is also valid, don't override the mimeType and leave it as \
"text/xml", so we actually do parse the reponse.
Confirmed by
http://www.w3.org/TR/XMLHttpRequest/#document-response-entity-body
"If final MIME type is not null, text/html, text/xml, application/xml, or does \
not end in +xml, return null and terminate these steps." ~~
means, if it is one of these above -> continue
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/xmlhttprequest.cpp <span style="color: grey">(cd72fe8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108928/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic