[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: ksysguard - Add rowspan/colspan support for displays
From: John Tapsell <johnflux () gmail ! com>
Date: 2013-01-04 20:11:45
Message-ID: CAHQ6N+o40hqxCEq6wzbOzrN-Rdyn3Hp8hqU6FmT4v83yHYEfhQ () mail ! gmail ! com
[Download RAW message or body]
Hi,
I'm the maintainer. The review gets my approval, but I'm a bit busy.
Can someone else apply this please?
Thank you very much,
John
On 4 January 2013 19:44, Arnavion <arnavion@gmail.com> wrote:
> Hi,
> I don't see this review request e-mail on the mailman archives, so I'm not
> sure it ever made it to the mailing list. Apologies if it did.
> I did get an e-mail that the message "is being held until the list
> moderator can review it for approval", but I didn't receive any follow-up
> e-mails about that.
> Arnav Singh
>
>
>
> On Thu, Dec 27, 2012 at 7:50 PM, Arnav Singh <arnavion@gmail.com> wrote:
>
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/107970/
> > Review request for kde-workspace.
> > By Arnav Singh.
> > Description
> >
> > I've added support for sensor displays in KSysGuard to have row spans and column \
> > spans.
> > Apart from adding rowSpan and columnSpan arguments to the method signatures, I've \
> > also removed the internal list (WorkSheet::mDisplayList) used to contain all the \
> > sensor displays. This list used to be used to derived the row and column of the \
> > displays based on their index in the list. Since I now need to maintain rowSpan \
> > and columnSpan information as well, I just removed the list entirely and get all \
> > my data from mGridLayout. As a result, another change in the method signatures is \
> > the replacement of the "index" parameter with "row" and "column" parameters.
> > An extra advantage of doing it this way is that widgets don't shift around when \
> > resizing the grid. Another advantage is that blank spaces between the widgets are \
> > now possible. Not to mention, not maintaining the layout information outside of \
> > the actual layout component (mGridLayout) seems a clearer design to me.
> > Testing
> >
> > Works on 4.9.4
> >
> > *Bugs: * 311925 <http://bugs.kde.org/show_bug.cgi?id=311925>
> > Diffs
> >
> > - ksysguard/gui/WorkSheet.h (9f4806d)
> > - ksysguard/gui/WorkSheet.cpp (b20f077)
> >
> > View Diff <http://git.reviewboard.kde.org/r/107970/diff/>
> > Screenshots
> > [image: Example] <http://git.reviewboard.kde.org/r/107970/s/936/>
> >
>
>
[Attachment #3 (text/html)]
Hi,<br> I'm the maintainer. The review gets my approval, but I'm a bit \
busy. <br><br> Can someone else apply this please?<br><br>Thank you very \
much,<br><br>John<br><br><div class="gmail_quote">On 4 January 2013 19:44, Arnavion \
<span dir="ltr"><<a href="mailto:arnavion@gmail.com" \
target="_blank">arnavion@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>Hi,</div><div> </div><div>I don't see \
this review request e-mail on the mailman archives, so I'm not sure it ever made \
it to the mailing list. Apologies if it did.</div>
<div> </div><div>I did get an e-mail that the message "is being held until the \
list moderator can review it for approval", but I didn't receive any \
follow-up e-mails about that.</div><span class="HOEnZb"><font color="#888888">
<div> </div><div>Arnav Singh</div><div> </div></font></span></div><div \
class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Thu, Dec 27, 2012 at 7:50 PM, Arnav Singh <span \
dir="ltr"><<a href="mailto:arnavion@gmail.com" \
target="_blank">arnavion@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px solid rgb(201,195,153)" bgcolor="#f9f3c9" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107970/" \
target="_blank">http://git.reviewboard.kde.org/r/107970/</a> </td>
</tr>
</tbody></table>
<br>
<table style="border:1px solid \
black;background-image:none;background-repeat:repeat-x" bgcolor="#fefadf" \
cellpadding="8" cellspacing="0" width="100%"> <tbody><tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Arnav Singh.</div>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid rgb(184,181,160)" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0px;padding:0px;white-space:pre-wrap;word-wrap:break-word">I've \
added support for sensor displays in KSysGuard to have row spans and column spans.
Apart from adding rowSpan and columnSpan arguments to the method signatures, I've \
also removed the internal list (WorkSheet::mDisplayList) used to contain all the \
sensor displays. This list used to be used to derived the row and column of the \
displays based on their index in the list. Since I now need to maintain rowSpan and \
columnSpan information as well, I just removed the list entirely and get all my data \
from mGridLayout. As a result, another change in the method signatures is the \
replacement of the "index" parameter with "row" and \
"column" parameters.
An extra advantage of doing it this way is that widgets don't shift around when \
resizing the grid. Another advantage is that blank spaces between the widgets are now \
possible. Not to mention, not maintaining the layout information outside of the \
actual layout component (mGridLayout) seems a clearer design to me.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid rgb(184,181,160)" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0px;padding:0px;white-space:pre-wrap;word-wrap:break-word">Works \
on 4.9.4</pre> </td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311925" target="_blank">311925</a>
</div>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="padding-left:0px;margin-left:3em">
<li>ksysguard/gui/WorkSheet.h <span style="color:grey">(9f4806d)</span></li>
<li>ksysguard/gui/WorkSheet.cpp <span style="color:grey">(b20f077)</span></li>
</ul>
<p><a style="margin-left:3em" href="http://git.reviewboard.kde.org/r/107970/diff/" \
target="_blank">View Diff</a></p>
<h1 style="color:rgb(87,80,18);font-size:10pt;margin-top:1.5em">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107970/s/936/" target="_blank"><img src="" \
style="border:1px solid black" alt="Example"></a>
</div>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div>
</div></div></blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic