On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid <span dir="ltr">&lt;<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<div><br>
</div>AttendeeInfo misses a d_ptr?</blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Are you deleting the d_ptr? Maybe i&#39;m missing something but for example you<br>
don&#39;t seem to delete the d_ptr of PagedListJob, no?<br></blockquote><div><br></div><div>I reworked the dpointers a bit, classes deriving directly from Facebook*Job are now extending its dpointer, which is then deleted in the baseclass (FacebookJob). All other dpointers are also properly deleted. Partly-related - our d-pointer tutorials don&#39;t delete it either [1][2].</div>

<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

You probably also want to add Q_DISABLE_COPY to most of the classes with<br>
d-pointers, otherwise the default constructor and operator= will do something<br>
that you don&#39;t really want.<br></blockquote><div><br></div><div>Fixed.</div><div><br></div><div>[1] - <a href="http://techbase.kde.org/Policies/Library_Code_Policy#D-Pointers" target="_blank">http://techbase.kde.org/Policies/Library_Code_Policy#D-Pointers</a></div>


<div>[2] - <a href="http://techbase.kde.org/Policies/Library_Code_Policy/Shared_D-Pointer_Example" target="_blank">http://techbase.kde.org/Policies/Library_Code_Policy/Shared_D-Pointer_Example</a></div><div> </div><div>Cheers</div>

</div>-- <br>
<div><span style="color:rgb(102,102,102)">Martin Klapetek | KDE Developer</span></div>