[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add some new User Agent files for spoofing browser identities in konqueror, reko
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2013-01-01 5:13:56
Message-ID: 20130101051356.6295.70897 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108057/#review24355
-----------------------------------------------------------
Ship it!
Why 3 separate descriptions for Chrome ? Wouldn't the last 2 just like the =
other ones suffice ? Anyways, it would be nice if we could simply remove al=
l the old and unsupported user-agent strings. Perhaps we should do that for=
4.10.1.
- Dawit Alemayehu
On Dec. 31, 2012, 10:25 p.m., Guillaume de Bure wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108057/
> -----------------------------------------------------------
> =
> (Updated Dec. 31, 2012, 10:25 p.m.)
> =
> =
> Review request for KDE Base Apps.
> =
> =
> Description
> -------
> =
> I find that the current list of Browser identities that you can use in ko=
nqueror or rekonq is so very obsolete... I used information from http://www=
.useragentstring.com/pages/Browserlist/ and wrote some additional .desktop =
files, specifically:
> * Chrome 22, 23, 24
> * Firefox 15, 16
> * IE 8, 9
> * Opera 11, 12
> * Safari 5, 6
> =
> I purposely did not update the CMakeLists.txt yet, waiting for some initi=
al feedback first. I also intend to remove some other entries from the curr=
ent file list, unsure whether that should come in a separate review request
> =
> =
> Diffs
> -----
> =
> konqueror/settings/kio/uasproviders/chrome22oncurrent.desktop PRE-CREAT=
ION =
> konqueror/settings/kio/uasproviders/chrome23oncurrent.desktop PRE-CREAT=
ION =
> konqueror/settings/kio/uasproviders/chrome24oncurrent.desktop PRE-CREAT=
ION =
> konqueror/settings/kio/uasproviders/firefox15oncurrent.desktop PRE-CREA=
TION =
> konqueror/settings/kio/uasproviders/firefox16oncurrent.desktop PRE-CREA=
TION =
> konqueror/settings/kio/uasproviders/ie80onwinnt60.desktop PRE-CREATION =
> konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop PRE-CREATION =
> konqueror/settings/kio/uasproviders/op1162oncurrent.desktop PRE-CREATIO=
N =
> konqueror/settings/kio/uasproviders/op1202oncurrent.desktop PRE-CREATIO=
N =
> konqueror/settings/kio/uasproviders/safari517.desktop PRE-CREATION =
> konqueror/settings/kio/uasproviders/safari60.desktop PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/108057/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Guillaume de Bure
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108057/">http://git.reviewboard.kde.org/r/108057/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Why 3 separate descriptions for Chrome ? Wouldn't the last 2 \
just like the other ones suffice ? Anyways, it would be nice if we could simply remove all the old and \
unsupported user-agent strings. Perhaps we should do that for 4.10.1.</pre> <br />
<p>- Dawit</p>
<br />
<p>On December 31st, 2012, 10:25 p.m., Guillaume de Bure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Guillaume de Bure.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 10:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I find that the current list of Browser \
identities that you can use in konqueror or rekonq is so very obsolete... I used information from \
http://www.useragentstring.com/pages/Browserlist/ and wrote some additional .desktop \
files, specifically:
* Chrome 22, 23, 24
* Firefox 15, 16
* IE 8, 9
* Opera 11, 12
* Safari 5, 6
I purposely did not update the CMakeLists.txt yet, waiting for some initial feedback first. I also intend \
to remove some other entries from the current file list, unsure whether that should come in a separate \
review request</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/settings/kio/uasproviders/chrome22oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome23oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/chrome24oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox15oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/firefox16oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/ie80onwinnt60.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/ie90onwinnt71.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/op1162oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/op1202oncurrent.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/safari517.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>konqueror/settings/kio/uasproviders/safari60.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108057/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic