[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving libkfacebook to extragear
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2012-12-29 0:25:43
Message-ID: CAPLgePo7JUkMZtxkiSxuNy2CoHxOD6JuJxiBigP1YR2Dm92B2A () mail ! gmail ! com
[Download RAW message or body]

On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid <aacid@kde.org> wrote:

> > The data classes are finally done - all of them now use d-pointers and
> none
> > are qobject; I've added the qobject-parsers as Kevin suggested, please
> give
> > it a look.
>
> You sure? I still see a lots of d-pointers missing (AllEventsListJob,
> AllNotesListJob, etc).
>

I finally got around finishing d-pointerizing the whole library, it's all
in master now. Please review.


> Also you have some classes without the export thingie, like AttendeeInfo or
> the facebookTimeToKDateTime function
>

Fixed.

-- 
Martin Klapetek | KDE Developer

[Attachment #3 (text/html)]

<div dir="ltr">On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid <span dir="ltr">&lt;<a \
href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>&gt;</span> wrote:</div><div \
class="gmail_extra"><div class="gmail_quote">


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div>&gt; The data classes are finally done - all of them now use d-pointers and \
none<br> &gt; are qobject; I&#39;ve added the qobject-parsers as Kevin suggested, please give<br>
&gt; it a look.<br>
<br>
</div>You sure? I still see a lots of d-pointers missing (AllEventsListJob,<br>
AllNotesListJob, etc).<br></blockquote><div><br></div><div>I finally got around finishing d-pointerizing \
the whole library, it&#39;s all in master now. Please review.</div><div>  </div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


Also you have some classes without the export thingie, like AttendeeInfo or<br>
the facebookTimeToKDateTime \
function<br></blockquote><div><br></div><div>Fixed.</div><div><br></div></div>-- <br><div><span \
style="color:rgb(102,102,102)">Martin Klapetek | KDE  Developer</span></div> </div>



[prev in list] [next in list] [prev in thread] [next in thread]