[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Mutex cleanup in KSharedDataCache
From: "Vadim Zhukov" <persgray () gmail ! com>
Date: 2012-08-27 8:50:29
Message-ID: 20120827085029.10331.98751 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106221/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 8:50 a.m.)
Review request for kdelibs and Michael Pyne.
Changes
-------
Added error text printing, as requested by mpyne@.
Please note: strerror() is not thread-safe, so we have to use strerror_r(), which \
doesn't exists everywhere. So I've added another CMake check, and if it fails, still \
print error code directly.
Description
-------
- Remove "support" for thread-shared-only locks: they do not help at all but makes \
app crash instead of slowly work; lack of decent locks to be resolved \
later.
- Add error checking with console printouts.
- Consistently use "::" before global functions.
Probably failed mutexes should be destroyed in case of some errors, any thoughts?
This addresses bug 305023.
http://bugs.kde.org/show_bug.cgi?id=305023
Diffs (updated)
-----
kdecore/util/ConfigureChecks.cmake fe9f47e
kdecore/util/config-util.h.cmake 83ccdf7
kdecore/util/kshareddatacache.cpp 393902e
kdecore/util/kshareddatacache_p.h ec5a7a0
Diff: http://git.reviewboard.kde.org/r/106221/diff/
Testing
-------
On OpenBSD-CURRENT.
Thanks,
Vadim Zhukov
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106221/">http://git.reviewboard.kde.org/r/106221/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Michael Pyne.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 8:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added error text printing, as requested by mpyne@. Please note: \
strerror() is not thread-safe, so we have to use strerror_r(), which doesn't \
exists everywhere. So I've added another CMake check, and if it fails, still \
print error code directly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Remove "support" for thread-shared-only locks: they do not \
help at all but makes app crash instead of slowly work; lack of decent locks to be \
resolved later.
- Add error checking with console printouts.
- Consistently use "::" before global functions.
Probably failed mutexes should be destroyed in case of some errors, any \
thoughts?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On OpenBSD-CURRENT.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305023">305023</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/util/ConfigureChecks.cmake <span style="color: \
grey">(fe9f47e)</span></li>
<li>kdecore/util/config-util.h.cmake <span style="color: grey">(83ccdf7)</span></li>
<li>kdecore/util/kshareddatacache.cpp <span style="color: \
grey">(393902e)</span></li>
<li>kdecore/util/kshareddatacache_p.h <span style="color: \
grey">(ec5a7a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106221/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic