[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Do not crash avahi DNSSD service
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-07-19 1:55:52
Message-ID: 20120719015552.19993.12938 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105613/
-----------------------------------------------------------
Review request for kdelibs, KTorrent, Joris Guisson, and Thiago Macieira.
Description
-------
This is my attempt to fix the crash. As far as I followed the code, the crash is \
because of m_group == 0 in serverStateChanged() when the avahi server is initially \
"registering" or in "collision", and not "running" yet. When e.g. KTorrent starts, it \
is possible that the avahi server needs some time until it is fully setup. The \
m_group is initialized when the first tryApply() is called, which only happens when \
server is initially in "running" state.
Additionally, the m_running variable was never reset to false in stop(), so the \
(sync) publish() would never return on failure.
This addresses bug 215288.
http://bugs.kde.org/show_bug.cgi?id=215288
Diffs
-----
dnssd/avahi-publicservice.cpp 52bef22
Diff: http://git.reviewboard.kde.org/r/105613/diff/
Testing
-------
I have no idea what avahi is or how it works, so I did not test it.
Thanks,
Christoph Feck
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105613/">http://git.reviewboard.kde.org/r/105613/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, KTorrent, Joris Guisson, and Thiago Macieira.</div>
<div>By Christoph Feck.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is my attempt to fix the crash. As far as I followed the code, the \
crash is because of m_group == 0 in serverStateChanged() when the avahi server is \
initially "registering" or in "collision", and not \
"running" yet. When e.g. KTorrent starts, it is possible that the avahi \
server needs some time until it is fully setup. The m_group is initialized when the \
first tryApply() is called, which only happens when server is initially in \
"running" state.
Additionally, the m_running variable was never reset to false in stop(), so the \
(sync) publish() would never return on failure.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have no idea what avahi is or how it works, so I did not test \
it.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=215288">215288</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dnssd/avahi-publicservice.cpp <span style="color: grey">(52bef22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105613/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic