[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: fix the rect passed to kcapacitybar paint method
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-01-10 19:49:48
Message-ID: 20120110194948.5076.82289 () vidsolbach ! de
[Download RAW message or body]
> On Jan. 10, 2012, 6:08 p.m., Thomas Lübking wrote:
> > kdeui/widgets/kcapacitybar.cpp, line 374
> > <http://git.reviewboard.kde.org/r/103669/diff/2/?file=46380#file46380line374>
> >
> > rather "..., contentsRect());"
> > Otherwise looks fine (i guess setCllipRegion() is overhead)
>
> Hugo Pereira Da Costa wrote:
> Concerning setClipRegion() overhead, no clue.
>
> Concerning passing contentsRect() instead of rect(), well, QStyleOption::initFrom \
> uses widget->rect() by default. Now, other widgets implementation might use \
> contentsRect() when initializing their options. Testing, both work (I guess cause \
> the margin is zero :)).
Margins default to zero, so unless sbd. sets sth. different on the capacitybar \
there's no difference. What is the correct one depends on "do i want to have the \
style painting the margin as well"
Since the entire stuff was added about Qt 4.6 or so (with advanced styleShitting \
[sic! ;-] support) it seems expectable that several widgets simply ignore it, esp. \
esp. for the default implementation of QStyleOption (could be to paint the widget \
background of a WA_StyledBackground window etc.)
My impression in this context was that the contentsRect is addressed. *shrug*
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103669/#review9716
-----------------------------------------------------------
On Jan. 10, 2012, 5:06 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103669/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2012, 5:06 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> fixes the rect passed to paint method so that it matches the widget rect and not \
> the event (clip) rect, since the former is what's expected by widget styles.
>
> This addresses bug 290879.
> http://bugs.kde.org/show_bug.cgi?id=290879
>
>
> Diffs
> -----
>
> kdeui/widgets/kcapacitybar.cpp 6e63c3f
>
> Diff: http://git.reviewboard.kde.org/r/103669/diff/diff
>
>
> Testing
> -------
>
> Fixes bug above.
> No regression with other styles.
>
>
> Thanks,
>
> Hugo Pereira Da Costa
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103669/">http://git.reviewboard.kde.org/r/103669/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 10th, 2012, 6:08 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103669/diff/2/?file=46380#file46380line374" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/widgets/kcapacitybar.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QSize \
KCapacityBar::minimumSizeHint() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">374</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">drawCapacityBar</span><span class="p">(</span><span \
class="o">&</span><span class="n">p</span><span class="p">,</span> <span \
class="n">rect</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rather "..., \
contentsRect());" Otherwise looks fine (i guess setCllipRegion() is \
overhead)</pre> </blockquote>
<p>On January 10th, 2012, 6:37 p.m., <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concerning \
setClipRegion() overhead, no clue.
Concerning passing contentsRect() instead of rect(), well, QStyleOption::initFrom \
uses widget->rect() by default. Now, other widgets implementation might use \
contentsRect() when initializing their options. Testing, both work (I guess cause the \
margin is zero :)).</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Margins \
default to zero, so unless sbd. sets sth. different on the capacitybar there's no \
difference. What is the correct one depends on "do i want to have the style \
painting the margin as well"
Since the entire stuff was added about Qt 4.6 or so (with advanced styleShitting \
[sic! ;-] support) it seems expectable that several widgets simply ignore it, esp. \
esp. for the default implementation of QStyleOption (could be to paint the widget \
background of a WA_StyledBackground window etc.)
My impression in this context was that the contentsRect is addressed. *shrug*</pre>
<br />
<p>- Thomas</p>
<br />
<p>On January 10th, 2012, 5:06 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 5:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixes the rect passed to paint method so that it matches the widget rect \
and not the event (clip) rect, since the former is what's expected by widget \
styles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes bug above. No regression with other styles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=290879">290879</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kcapacitybar.cpp <span style="color: grey">(6e63c3f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103669/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic