From kde-core-devel Fri Jul 22 15:05:13 2011 From: "Commit Hook" Date: Fri, 22 Jul 2011 15:05:13 +0000 To: kde-core-devel Subject: =?utf-8?q?Re=3A_Review_Request=3A_Make_=E2=80=9CEdit_File_Type=E2=80=9D_b?= Message-Id: <20110722150513.9713.89428 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=131134717502688 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5238116182834913214==" --===============5238116182834913214== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101800/#review4975 ----------------------------------------------------------- This review has been submitted with commit 131fabf76ec4688561892ba87e2aa86a= d828ca70 by Kai Uwe Broulik to branch master. - Commit On June 30, 2011, 10:34 p.m., Kai Uwe Broulik wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101800/ > ----------------------------------------------------------- > = > (Updated June 30, 2011, 10:34 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > On IRC this evening somebody found it hard to find the options to edit a = specific file type. The KCM is a mess unfortunately but I told him that you= could edit specific file types directly from the properties dialog. > That button is hard to spot, though, which I also often found annoying. I= t is neither labled nor does it stand out as =E2=80=9Cbutton=E2=80=9D. > This patch solves that issue. > = > It is in need of discussion whether the label itself should stay but the = button definitly has to look like a clickable target. > = > Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screen= shot is from the initial attempt where i forgot the capitalization :P) > = > = > Diffs > ----- > = > kio/kfile/kpropertiesdialog.cpp 3382daa = > = > Diff: http://git.reviewboard.kde.org/r/101800/diff > = > = > Testing > ------- > = > = > Thanks, > = > Kai Uwe > = > --===============5238116182834913214== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101800/

This revie=
w has been submitted with commit 131fabf76ec4688561892ba87e2aa86ad828ca70 b=
y Kai Uwe Broulik to branch master.

- Commit

On June 30th, 2011, 10:34 p.m., Kai Uwe Broulik wrote:

Review request for kdelibs.

By Kai Uwe Broulik.

Updated June 30, 2011, 10:34 p.m.

Descripti= on

On IRC this evening somebody found it hard to find the optio=
ns to edit a specific file type. The KCM is a mess unfortunately but I told=
 him that you could edit specific file types directly from the properties d=
ialog.
That button is hard to spot, though, which I also often found annoying. It =
is neither labled nor does it stand out as =E2=80=9Cbutton=E2=80=9D.
This patch solves that issue.

It is in need of discussion whether the label itself should stay but the bu=
tton definitly has to look like a clickable target.

Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screensh=
ot is from the initial attempt where i forgot the capitalization :P)

Diffs=

kio/kfile/kpropertiesdialog.cpp (3382daa)<= /span>

--===============5238116182834913214==--