'Review Request: PATCH: Honor size and coordinates when creating new'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: PATCH: Honor size and coordinates when creating new
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-05-31 17:41:30
Message-ID: 20110531174130.8839.38211 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101477/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Summary
-------

Currently new window creation in KonqMainWindow::slotCreateNewWindow does n=
ot honor the supplied cooridnate and size information under certain circums=
tances. For example, if you click on a javascript link that opens a new win=
dow, then the new window will always be maximized, regardless of the size i=
nformation supplied by the javascript window.open call, as long as the Konq=
ueror window where you clicked on the link is also maximized. Even when the=
 original window is not maximized, if you maximize and close the newly crea=
ted window, then clicking on the javscript window.open link again will resu=
lt in a maximized window.

The attached patch addresses all of the above issues by making sure the coo=
rdinate and size information are always honored during new window creation.


Diffs
-----

  konqueror/src/konqmainwindow.cpp 56aa379 =


Diff: http://git.reviewboard.kde.org/r/101477/diff


Testing
-------


Thanks,

Dawit


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101477/">http://git.reviewboard.kde.org/r/101477/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently new window creation in KonqMainWindow::slotCreateNewWindow \
does not honor the supplied cooridnate and size information under certain \
circumstances. For example, if you click on a javascript link that opens a new \
window, then the new window will always be maximized, regardless of the size \
information supplied by the javascript window.open call, as long as the Konqueror \
window where you clicked on the link is also maximized. Even when the original window \
is not maximized, if you maximize and close the newly created window, then clicking \
on the javscript window.open link again will result in a maximized window.

The attached patch addresses all of the above issues by making sure the coordinate \
and size information are always honored during new window creation.

</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(56aa379)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101477/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic