[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: make the add search engine window right aligned
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-05-30 22:33:18
Message-ID: 20110530223318.27276.54813 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101475/#review3599
-----------------------------------------------------------
Ship it!
Would that not simply make the reverse true, i.e. the dialog might be too large in \
the opposite direction ? Anyhow, at least it won't be outside of the konqueror window \
; so I personally have no objections to this.
- Dawit
On May 30, 2011, 8:26 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101475/
> -----------------------------------------------------------
>
> (Updated May 30, 2011, 8:26 p.m.)
>
>
> Review request for KDE Base Apps, Dawit Alemayehu and David Faure.
>
>
> Summary
> -------
>
> Currently the add search engine window is left aligned to the left side of the \
> search bar. E. g. using locales with long translations of the window title "Set URI \
> Shortcuts" (or other strings in the window) like eg fr part of the window to add \
> the search engine is outside the screen, because the translated string is longer \
> than the search bar. The patch makes the window right aligned at the end of the \
> search bar, than no matter how long the translated string is the whole window will \
> be always inside konquerors main window.
> Screenshot in locale fr before the patch showing the bug: \
> http://bugsfiles.kde.org/attachment.cgi?id=52424
> Screenshot in locale fr with the patch (one with / one without throbber): \
> http://bugsfiles.kde.org/attachment.cgi?id=60484
>
> This addresses bug 253879.
> http://bugs.kde.org/show_bug.cgi?id=253879
>
>
> Diffs
> -----
>
> konq-plugins/searchbar/searchbar.cpp c7aa301
>
> Diff: http://git.reviewboard.kde.org/r/101475/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101475/">http://git.reviewboard.kde.org/r/101475/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would that not simply \
make the reverse true, i.e. the dialog might be too large in the opposite direction ? \
Anyhow, at least it won't be outside of the konqueror window ; so I personally \
have no objections to this.</pre> <br />
<p>- Dawit</p>
<br />
<p>On May 30th, 2011, 8:26 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps, Dawit Alemayehu and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 30, 2011, 8:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the add search engine window is left aligned to the left side \
of the search bar. E. g. using locales with long translations of the window title \
"Set URI Shortcuts" (or other strings in the window) like eg fr part of the \
window to add the search engine is outside the screen, because the translated string \
is longer than the search bar. The patch makes the window right aligned at the end \
of the search bar, than no matter how long the translated string is the whole window \
will be always inside konquerors main window.
Screenshot in locale fr before the patch showing the bug: \
http://bugsfiles.kde.org/attachment.cgi?id=52424
Screenshot in locale fr with the patch (one with / one without throbber): \
http://bugsfiles.kde.org/attachment.cgi?id=60484</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=253879">253879</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konq-plugins/searchbar/searchbar.cpp <span style="color: \
grey">(c7aa301)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101475/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic