[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: add help button + action to Spell Checking
From: "Allen Winter" <winter () kde ! org>
Date: 2011-05-17 14:15:50
Message-ID: 20110517141550.12893.53609 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101373/#review3363
-----------------------------------------------------------
Ship it!
could you also make sure to cherry-pick this into the 4.6 branch?
- Allen
On May 16, 2011, 9:08 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101373/
> -----------------------------------------------------------
>
> (Updated May 16, 2011, 9:08 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Launching the dialog in systemsettings (Locale->Spell Checker) it has a Help button \
> opening the docbook help:/kcontrol/spellchecking/. But using this dialog from \
> several apps (konqui->Tools->Configure Spell Checking, kmail composer Settings menu \
> etc) this help button is missing.
>
> This addresses bug 213817.
> http://bugs.kde.org/show_bug.cgi?id=213817
>
>
> Diffs
> -----
>
> kdeui/sonnet/configdialog.cpp 8bb4923
>
> Diff: http://git.reviewboard.kde.org/r/101373/diff
>
>
> Testing
> -------
>
> build, works.
>
>
> Thanks,
>
> Burkhard
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101373/">http://git.reviewboard.kde.org/r/101373/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could you also make sure \
to cherry-pick this into the 4.6 branch?</pre> <br />
<p>- Allen</p>
<br />
<p>On May 16th, 2011, 9:08 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 16, 2011, 9:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Launching the dialog in systemsettings (Locale->Spell Checker) it has \
a Help button opening the docbook help:/kcontrol/spellchecking/. But using this \
dialog from several apps (konqui->Tools->Configure Spell Checking, kmail \
composer Settings menu etc) this help button is missing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build, works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=213817">213817</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/sonnet/configdialog.cpp <span style="color: grey">(8bb4923)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101373/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic