[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: konqueror: reset URL when pressing ESC in address
From: "David Faure" <faure () kde ! org>
Date: 2011-05-16 6:50:29
Message-ID: 20110516065029.27495.88780 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/#review10125
-----------------------------------------------------------
Why do this in a key press handler? It means that hitting the Stop button with the \
mouse and pressing the Esc key will do something different.
Better do this in the slot connected to the stop action, then it will work for both.
- David
On May 15, 2011, 7:59 p.m., Marcel Partap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
> -----------------------------------------------------------
>
> (Updated May 15, 2011, 7:59 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Summary
> -------
>
> Attempted patch to make konqueror reset the URL when escape is pressed in the \
> address bar. For reasons beyond my grokledge does not always seem to work.
>
> This addresses bug 257841.
> https://bugs.kde.org/show_bug.cgi?id=257841
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388
>
> Diff: http://svn.reviewboard.kde.org/r/6681/diff
>
>
> Testing
> -------
>
> see https://bugs.kde.org/show_bug.cgi?id=257841#c0
>
>
> Thanks,
>
> Marcel
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6681/">http://svn.reviewboard.kde.org/r/6681/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do this in a key \
press handler? It means that hitting the Stop button with the mouse and pressing the \
Esc key will do something different.
Better do this in the slot connected to the stop action, then it will work for \
both.</pre> <br />
<p>- David</p>
<br />
<p>On May 15th, 2011, 7:59 p.m., Marcel Partap wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Marcel Partap.</div>
<p style="color: grey;"><i>Updated May 15, 2011, 7:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attempted patch to make konqueror reset the URL when escape is pressed \
in the address bar. For reasons beyond my grokledge does not always seem to \
work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://bugs.kde.org/show_bug.cgi?id=257841#c0</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=257841">257841</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp <span style="color: \
grey">(1200388)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6681/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic