[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review kdelibs whiting/fixQByteArrays
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2011-05-02 17:37:58
Message-ID: 201105021937.58786.ogoffart () kde ! org
[Download RAW message or body]

Le Monday 02 May 2011, David Faure a écrit :
 
> Another one:
> 
> -      envs << QString::fromLatin1( QByteArray("DISPLAY=") + dpystring );
> +    envs << QString::fromLatin1( QByteArray(QByteArray("DISPLAY=") +
> dpystring) );

Should be QLatin1String("DISPLAY=") + QLatin1String(dpystring)
(Assuming dpystring is char*)


> 
> Is this still because QString::fromLatin1( const QByteArray& ) is missing,
> so it has to cast to const char* here too? Olivier, wouldn't it make sense
> to have such an overload? (It would save a strlen, too).

Yes, maybe  QString::fromLatin1(const QByteArray&) would make sens
But it might brake source compatibility if the call becomes ambiguous.

The reason why we brake source compatibility with QT_USE_FAST_OPERATOR_PLUS is 
because this one was not documented.  But maybe the new operator should only 
be enabled if QT_USE_FAST_OPERATOR_PLUS is defined to 2 or something.





[prev in list] [next in list] [prev in thread] [next in thread]