[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Hidden KDED desktop file crashing systemsettings - where to fix?
From:       David Faure <faure () kde ! org>
Date:       2010-11-03 15:22:50
Message-ID: 201011031622.51479.faure () kde ! org
[Download RAW message or body]

On Wednesday 03 November 2010, Jonathan Marten wrote:
> Possibly the "if ( KDesktopFile::isDesktopFile( ... ) )" is redundant,
> but I've tried not to change the structure of the original code too
> much.  If anyone thinks this could be cut out, then I'll happily do that.

Yes, it can be cut out, only .desktop files are known as services in ksycoca.

Patch looks good otherwise.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
[prev in list] [next in list] [prev in thread] [next in thread]