'Re: Code transitions - Theme transitions'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-core-devel
Subject: Re: Code transitions - Theme transitions
From: Peter Penz <peter.penz () gmx ! at>
Date: 2008-12-03 15:28:50
Message-ID: 200812031628.51345.peter.penz () gmx ! at
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sunday, 30. November 2008 04:56:05 Sebastian Kügler wrote:
> On Sunday 23 November 2008 11:37:13 Peter Penz wrote:
> > * I faced a crash (see [2]) in Kate that is related to the treeview
> > animation.
>
> Can you check if patch 0262 in qt-copy fixes this problem for you? It's
> revision 889120.

I just did an update and the crash seems to be fixed :-) 

BTW: the patch from David Nolden, which disables the animation generally 
because of another issue (see attachment), was not applied for my tests.

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd">
<html><head><meta name="qrichtext" content="1" /><style type="text/css">
p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:10pt; font-weight:400; \
font-style:normal;"> On Sunday, 30. \
November 2008 04:56:05 Sebastian Kügler wrote: &gt; On Sunday 23 November 2008 11:37:13 Peter Penz wrote: &gt; &gt; * I faced a crash (see [2]) in Kate that is \
related to the treeview &gt; &gt; \
animation. &gt; &gt; Can you check if patch 0262 in qt-copy fixes this problem for you? \
It's &gt; revision 889120. I just did an update and the crash seems to be fixed :-) \
 BTW: the patch from David Nolden, which disables the \
animation generally because of another issue (see attachment), was not applied for my \
tests.</body></html>


["forwarded message" (message/rfc822)]

Return-Path: <commitfilter@new.kstuff.org>
X-Flags: 1001
Delivered-To: GMX delivery to peter.penz@gmx.at
Received: (qmail invoked by alias); 03 Dec 2008 14:19:41 -0000
Received: from kdeget.osuosl.org (EHLO kdeget.osuosl.org) [140.211.166.77]
 by mx0.gmx.net (mx073) with SMTP; 03 Dec 2008 15:19:41 +0100
Received: from ktown.kde.org ([131.246.120.250])
	by kdeget.osuosl.org with smtp (Exim 4.63)
	(envelope-from <kde-commits-bounces-+commitfilter=new.kstuff.org@kde.org>)
	id 1L7sZ3-0008HO-NM
	for commitfilter@new.kstuff.org; Wed, 03 Dec 2008 15:18:54 +0100
Received: (qmail 27676 invoked by uid 72); 3 Dec 2008 14:18:47 -0000
Received: (qmail 27568 invoked from network); 3 Dec 2008 14:18:43 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on ktown.kde.org
Received: from unknown (HELO office.kde.org) (195.135.221.67)
	by ktown.kde.org with SMTP; 3 Dec 2008 14:18:41 -0000
Received: from svn.kde.org (localhost [127.0.0.1])
	by office.kde.org (Postfix) with SMTP id 6C10F17E
	for <kde-commits@kde.org>; Wed, 3 Dec 2008 15:18:41 +0100 (CET)
Received: (nullmailer pid 28927 invoked by uid 30);
	Wed, 03 Dec 2008 14:18:41 -0000
From: David Nolden <david.nolden.kde@art-master.de>
To: kde-commits@kde.org
Subject: KDE/kdelibs/kdeui/kernel
X-Commit-Directories: (0) trunk/KDE/kdelibs/kdeui/kernel
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit
Date: Wed, 03 Dec 2008 14:18:41 +0000
Message-Id: <1228313921.118959.28926.nullmailer@svn.kde.org>
X-BeenThere: kde-commits@kde.org
X-Mailman-Version: 2.1.9
Precedence: list
Reply-To: kde-commits@kde.org
List-Id: Notification of KDE commits <kde-commits.kde.org>
List-Unsubscribe: <https://mail.kde.org/mailman/listinfo/kde-commits>,
	<mailto:kde-commits-request@kde.org?subject=unsubscribe>
List-Post: <mailto:kde-commits@kde.org>
List-Help: <mailto:kde-commits-request@kde.org?subject=help>
List-Subscribe: <https://mail.kde.org/mailman/listinfo/kde-commits>,
	<mailto:kde-commits-request@kde.org?subject=subscribe>
X-GMX-Antivirus: 0 (no virus found)
X-GMX-Htest: 0.45
X-GMX-Antispam: 0 (Mail was not recognized as spam)
X-GMX-UID: NtNQI+ofaHI/6qG3GiUlVRhqamdhZMRL
X-Length: 4100
X-UID: 499

SVN commit 892088 by zwabel:

Revert r886671
The problem:
This simply totally breaks with a very large tree like the completion-tree in KDevelop. The \
animations seem to be also triggered when a node is expanded internally by the application. \
This makes QTreeView want to paint the complete tree of ten thousands of items even when only 5 \
are visible, totally bringing down the application for half a minute. Also this triggers the \
following X error, probably because the painted area is too large:

X Error: RenderBadPicture (invalid Picture parameter) 182
 Extension: 158 (RENDER)
 Minor opcode: 5 (RenderChangePicture)
 Resource id: 0x4c028a9
X Error: BadGC (invalid GC parameter) 13
 Major opcode: 56 (X_ChangeGC)
 Resource id: 0x4c02

Sorry ereslibre for spoiling it once again.. but I cannot think of another way of fixing this



 M +1 -6 kstyle.cpp

--- trunk/KDE/kdelibs/kdeui/kernel/kstyle.cpp #892087:892088
@@ -50,7 +50,7 @@
 #include <QtCore/QCache>
 #include <QtCore/QEvent>
 #include <QtCore/QVariant>
-#include <QtGui/QTreeView>
+#include <QtGui/QAbstractItemView>
 #include <QtGui/QApplication>
 #include <QtGui/QDialogButtonBox>
 #include <QtGui/QFormLayout>
@@ -403,11 +403,6 @@
     // Enable hover effects in all itemviews
     if (QAbstractItemView *itemView = qobject_cast<QAbstractItemView*>(w) ) {
         itemView->viewport()->setAttribute(Qt::WA_Hover);
-
-        if (QTreeView *treeView = qobject_cast<QTreeView*>(w)) {
-            KGlobalSettings::GraphicEffects graphicEffects = (KGlobalSettings::GraphicEffects) \
d->m_componentData.config()->group("KDE-Global GUI Settings").readEntry("GraphicEffectsLevel", \
                (int) KGlobalSettings::NoEffects);
-            treeView->setAnimated(graphicEffects & KGlobalSettings::SimpleAnimationEffects);
-        }
     }
 
     QCommonStyle::polish(w);



[prev in list] [next in list] [prev in thread] [next in thread] 
