[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fix a crash in KSharedConfigPtr
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2007-08-31 19:22:14
Message-ID: Pine.LNX.4.64.0708312121480.22537 () calcifer ! valdyas ! org
[Download RAW message or body]

On Fri, 31 Aug 2007, Thiago Macieira wrote:

> On Thursday 30 August 2007 19:52:09 Matthias Kretz wrote:
> > On Thursday 30 August 2007, Alex Merry wrote:
> > > I'm getting a crash in plasma caused by setting a KSharedConfigPtr to 0.
> > > It causes KSharedConfigPtr::attach(0) to be called, and then tries to
> > > dereference p (which is 0).
> > >
> > > This patch should fix it, but I'm not certain it's correct.  Can someone
> > > tell me whether it makes sense?
> >
> > Good catch, your fix is correct. And I think I should document that code a
> > bit more...
> 
> Yes, please. I introduced the crash when I tried to fix KSharedConfigPtr to 
> work with Qt 4.4.

Should this also be fixed in KisSharedPtr?

Boudewijn

[prev in list] [next in list] [prev in thread] [next in thread]