[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kdebase catching up with kdelibs (kkey)
From:       Hamish Rodda <rodda () kde ! org>
Date:       2006-04-01 2:14:27
Message-ID: 200604011314.29962.rodda () kde ! org
[Download RAW message or body]


On Saturday 01 April 2006 09:39, Adriaan de Groot wrote:
> I'm a little fuzzy on how things ought to be developed right now. When
> should things in kdebase be ported to kdelibs trunk? For instance, the
> attached patch brings libkonq up to date wrt. Chuslove's i18n changes from
> tuesday. Should I wait with that until the libs snapshot is updated?

Yes, kdebase should compile against kdelibs_snapshot.

> Similarly, there's Hamish's KAction changes, which break libkonq as well,
> in
>
> popup.insertItem(SmallIconSet("goto"), i18n( "&Move Here" ) + "\t" +
>  KKey::modFlagLabel( KKey::SHIFT ), 2 );
>
> OK, so KKey::SHIFT is now Qt::SHIFT, but what about modFlagLabel()? It
> wasn't in the 3.5 API, so it's vanished again without being documented.

Well, either QKeySequence(Qt::Key_Shift).toString(), or=20
KKeyServer::modToStringUser(Qt::SHIFT).

I'll update the docs...

Cheers,
Hamish.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]