[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Annoying build system problems
From:       Hans Meine <meine () kogs1 ! informatik ! uni-hamburg ! de>
Date:       2005-02-18 17:00:37
Message-ID: 200502181800.37622.meine () kogs ! informatik ! uni-hamburg ! de
[Download RAW message or body]

On Friday 18 February 2005 17:43, I wrote:
> I wonder if this is intended.  Applicable fixes that come to my mind right
> now would include making "prepend-path=true" the default, or (seems cleaner
> to me) to change the list of paths in the calls to KDE_FIND_PATH to be
> either empty or only include  [${prefix}/bin ${exec_prefix}/bin].  (Both
> solutions assume that paths like /usr/bin are in $PATH anyhow, which is
> reasonable IMHO.)  Wouldn't this make sense?

I guess attaching my old, hacky patch could be misleading.  Attached you'll 
find another one which just removes the default paths from KDE_FIND_PATH 
calls (only for freetype-config as an example).

I still think prepend-path=true should be default anyhow, and K_F_P should 
only be called with unusual, package-related paths if necessary.

Ciao, /  /
     /--/
    /  / ANS

["freetype-removepaths.patch" (text/x-diff)]

Index: kdelibs/kinit/configure.in.in
===================================================================
RCS file: /home/kde/kdelibs/kinit/configure.in.in,v
retrieving revision 1.1.2.3
diff -u -3 -p -r1.1.2.3 configure.in.in
--- kdelibs/kinit/configure.in.in	23 Sep 2004 14:06:34 -0000	1.1.2.3
+++ kdelibs/kinit/configure.in.in	18 Feb 2005 16:57:45 -0000
@@ -25,7 +25,7 @@ if test -n "$FONTCONFIG_CONFIG"; then
   fi
 fi
 
-KDE_FIND_PATH(freetype-config, KDEINIT_FREETYPE_CONFIG, [${prefix}/bin \
${exec_prefix}/bin /usr/bin /usr/local/bin /opt/local/bin]) \
+KDE_FIND_PATH(freetype-config, KDEINIT_FREETYPE_CONFIG)  if test -n \
"$KDEINIT_FREETYPE_CONFIG"; then  if test -n "$KDEINIT_FREETYPE_CONFIG"; then
       KDEINIT_XFT_INCLUDES="`$KDEINIT_FREETYPE_CONFIG --cflags` $FONTCONFIG_CFLAGS"
Index: kdebase/kcontrol/kfontinst/configure.in.in
===================================================================
RCS file: /home/kde/kdebase/kcontrol/kfontinst/configure.in.in,v
retrieving revision 1.22
diff -u -3 -p -r1.22 configure.in.in
--- kdebase/kcontrol/kfontinst/configure.in.in	3 Apr 2004 09:36:35 -0000	1.22
+++ kdebase/kcontrol/kfontinst/configure.in.in	18 Feb 2005 16:57:45 -0000
@@ -2,7 +2,7 @@
 
 FOUND_FREETYPE=0
 
-KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG, [${prefix}/bin ${exec_prefix}/bin \
/usr/bin /usr/local/bin /opt/local/bin], [ +KDE_FIND_PATH(freetype-config, \
FREETYPE_CONFIG, [], [  AC_MSG_WARN([Could not find libfreetype anywhere, check \
http://www.freetype.org/])  ])
 
Index: kdegraphics/kpovmodeler/configure.in.in
===================================================================
RCS file: /home/kde/kdegraphics/kpovmodeler/configure.in.in,v
retrieving revision 1.8
diff -u -3 -p -r1.8 configure.in.in
--- kdegraphics/kpovmodeler/configure.in.in	22 Apr 2004 21:47:05 -0000	1.8
+++ kdegraphics/kpovmodeler/configure.in.in	18 Feb 2005 16:57:45 -0000
@@ -29,7 +29,7 @@ if test "$KPOVMODELER_OPENGL" = "no"; th
 fi
 
 
-KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG, [${prefix}/bin ${exec_prefix}/bin \
/usr/local/bin /opt/local/bin]) +KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG)
 
 if test -n "$FREETYPE_CONFIG"; then
   vers=`$FREETYPE_CONFIG --version 2>/dev/null | sed -e 's/libfreetype //' | awk \
                'BEGIN { FS = "."; } { printf "%d", ($1 * 1000 + $2) * 1000 + $3;}'`
Index: kdegraphics/kpdf/configure.in.in
===================================================================
RCS file: /home/kde/kdegraphics/kpdf/configure.in.in,v
retrieving revision 1.7.2.1
diff -u -3 -p -r1.7.2.1 configure.in.in
--- kdegraphics/kpdf/configure.in.in	2 Sep 2004 21:30:15 -0000	1.7.2.1
+++ kdegraphics/kpdf/configure.in.in	18 Feb 2005 16:57:45 -0000
@@ -2,7 +2,7 @@ dnl ##### Check for FreeType 2.0.5+.
 dnl ##### (Note: FT_Get_Name_Index was added in FT 2.0.5, and is
 dnl ##### the reason that Xpdf requires 2.0.5+.)
 
-KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG, [${prefix}/bin ${exec_prefix}/bin \
/usr/local/bin /opt/local/bin], [ +KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG, \
[], [  AC_MSG_WARN([Could not find libfreetype anywhere, check \
http://www.freetype.org/])  ])
 
@@ -54,7 +54,7 @@ if test "$xpdf_cv_func_fseek64" = yes -a
 else
 	AC_DEFINE(HAVE_FSEEK64, 0)
 fi
-	  
+
 dnl #### Check for libt1
 AC_LANG_SAVE
 AC_LANG_CPLUSPLUS
Index: kdegraphics/ksvg/configure.in.in
===================================================================
RCS file: /home/kde/kdegraphics/ksvg/configure.in.in,v
retrieving revision 1.14
diff -u -3 -p -r1.14 configure.in.in
--- kdegraphics/ksvg/configure.in.in	1 Aug 2004 15:24:16 -0000	1.14
+++ kdegraphics/ksvg/configure.in.in	18 Feb 2005 16:57:45 -0000
@@ -75,7 +75,7 @@ if test -z "$FONTCONFIG_LIBS"; then
 fi
 
 # Check for freetype2
-KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG, [${prefix}/bin ${exec_prefix}/bin \
/usr/local/bin /opt/local/bin],) +KDE_FIND_PATH(freetype-config, FREETYPE_CONFIG)
 
 if test -n "$FREETYPE_CONFIG"; then
   vers=`$FREETYPE_CONFIG --version 2>/dev/null | awk 'BEGIN { FS = "."; } { printf \
"%d", ($1 * 1000 + $2) * 1000 + $3;}'` @@ -138,13 +138,13 @@ else
 				lcms_ver_line=`cat $LCMSHDR | grep '^/\* Version' `
 			fi
 			lcms_ver=`echo "$lcms_ver_line" | head -1 | cut -d ' ' -f 3 `
- 
+
 			# Get major and minor version numbers
 			lcms_var_maj=`echo $lcms_ver | cut -d . -f 1`
- 
+
 			# Some versions have a character attached to the end of minor version
 			lcms_var_min=`echo $lcms_ver | cut -d . -f 2 | sed 's,[^0-9],,g'`
- 
+
 			if test "$lcms_var_maj" -gt 1 || test "$lcms_var_min" -lt 9 ; then
 				LCMS_LIBS=''
 		fi



[prev in list] [next in list] [prev in thread] [next in thread]