[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fix KApplication for non-gui apps
From:       Waldo Bastian <bastian () kde ! org>
Date:       2005-02-17 11:09:01
Message-ID: 200502171209.04377.bastian () kde ! org
[Download RAW message or body]


On Thursday 17 February 2005 03:40, George Staikos wrote:
>    This evening, on the second most lousy flight I've ever been on (Air
> Canada can really suck sometimes), I got a chance to implement this patch
> for KApplication that Lars and I (well, mostly Lars) came up with.  It
> should fix the problems with creating a pixmap in non-gui mode.  It seems
> to be binary compatible, but it needs testing on different platforms.  Any
> comments?

I think it can fail to be BC when you have different alignment constraints. 
You can have padding between the two QPixmaps, between the two pointers and 
between the pointer and the char[] array.

Something like:

  struct oldPixmapType { QPixmap a; QPixmap b; };
  union {
     struct { QPixmap *icon; QPixmap *miniIcon; } pm;
     char padding[sizeof(oldPixmapType)];
  } aIconPixmap;

seems more reliable imho.

Cheers,
Waldo
-- 
bastian@kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian@suse.com  |   http://www.novell.com/products/desktop/eval.html

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]