[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Recent file action on toolbars
From:       Olivier Goffart <ogoffart () tiscalinet ! be>
Date:       2003-09-21 20:33:05
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Dimanche 21 Septembre 2003 20:35, Andras Mantia a écrit :
> On Sunday 21 September 2003 17:54, Olivier Goffart wrote:

> > My point is that a new KAction type for this usage ( "executing" a
> > selected action ) should be usefull...  (KListAction??)
>
> But in this case KRecentFilesAction should inherit from that one and I
> don't think it can be done in a BC way. I believe my solution is a good
> compromise until KDE 4.0.

Yes... anyway, what is the existing depracated KListAction used for
Maybe your patch could be apply in this class instead. (and also remove the 
checkmark if possible)
But i'm not sure if KListAction is ever used as a KSelectAction, so that would 
break the compatibility.
(KRecentFilesAction already inherits from KListAction)

> > This could be solved easily. We just need to create a default icon for
> > openRecent and put it automaticaly.
>
> Oh, you're right, but which icon should you select for default ? My
> suggestion is "fileopen" and I can patch the KStdAction::openRecent if
> there are no complains about the patch in general and this issue in
> particular.

personaly, i think you should see with artists to make a special icon (which 
could be almost similar to the open icon)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/bgsJz58lY8jWrL0RAlJFAKCPaskdbzF6PyMX8sZlewrcPN6q4QCeLJXd
aY9zoxecUR5tT3wJg5ct4HI=
=HoAj
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]