[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdebase/konqueror
From:       Matthias Elter <me () main-echo ! net>
Date:       1999-08-02 18:36:20
[Download RAW message or body]

On Mon, 02 Aug 1999, Harri Porten wrote:
> Matthias Elter wrote:
> > 
> > On Mon, 02 Aug 1999, Harri Porten wrote:
> > > CVS by elter wrote:
> > > >
> > > > Modified Files:
> > > >         konq_iconview.cc
> > > > Log Message:
> > > > - m_mouseMode = settings->mouseMode();
> > > > + m_mouseMode = (KIconContainer::MouseMode) settings->mouseMode();
> > > >
> > > > to make gcc2.95 happy
> > >
> > > Yes, it makes the compiler happy but should strike the programmer as
> > > error prone. It's a potential bug and should be fixed correctly.
> > 
> > It's the same enum but in different name spaces. Why is it a potential bug to
> > cast it?
> 
> Because it's only the same enum *now*. They live in different places,
> though, and if one day someone has the idea to change one of them
> without knowing of the other: Bang !

Yes I see, but this should be fixed by one of the konqy developers. The
problems afaik result from Simon moving the enum to two .h files to get rid of
mousemode.h.

Greetings,
Matthias

-- 
Matthias Elter
me@kde.org / me@main-echo.net
KDE developer
Computer science student university of Wuerzburg, Germany

[prev in list] [next in list] [prev in thread] [next in thread]