[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kio] src/filewidgets: Drop unnecessary isEmpty() check.
From:       Eike Hein <hein () kde ! org>
Date:       2014-07-31 8:09:03
Message-ID: E1XClQ7-00021N-9T () scm ! kde ! org
[Download RAW message or body]

Git commit 81628933c11cf32bb378407a797fa3f0bd806180 by Eike Hein.
Committed on 31/07/2014 at 08:08.
Pushed by hein into branch 'master'.

Drop unnecessary isEmpty() check.

REVIEW:119551

M  +3    -5    src/filewidgets/kfilepreviewgenerator.cpp

http://commits.kde.org/kio/81628933c11cf32bb378407a797fa3f0bd806180

diff --git a/src/filewidgets/kfilepreviewgenerator.cpp \
b/src/filewidgets/kfilepreviewgenerator.cpp index 3130670..6486df1 100644
--- a/src/filewidgets/kfilepreviewgenerator.cpp
+++ b/src/filewidgets/kfilepreviewgenerator.cpp
@@ -682,11 +682,9 @@ void \
KFilePreviewGenerator::Private::slotPreviewJobFinished(KJob *job)  \
m_previewJobs.removeAt(index);  
     if (m_previewJobs.isEmpty()) {
-        if (!m_pendingItems.isEmpty()) {
-            foreach (const KFileItem &item, m_pendingItems) {
-                if (item.isMimeTypeKnown()) {
-                    m_resolvedMimeTypes.append(item);
-                }
+        foreach (const KFileItem &item, m_pendingItems) {
+            if (item.isMimeTypeKnown()) {
+                m_resolvedMimeTypes.append(item);
             }
         }
 


[prev in list] [next in list] [prev in thread] [next in thread]