[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [kate] part/utils: Remaining Classes: Keys stored as constants
From:       Dominik Haumann <dhaumann () kde ! org>
Date:       2013-11-23 17:45:50
Message-ID: 2460902.kGh2IX9Ppe () eriador
[Download RAW message or body]

On Saturday 23 November 2013 07:06:34 Harsh Kumar wrote:
> Git commit fa107979f5363e1117ed92a93cff2a1ce32797de by Harsh Kumar.
> Committed on 23/11/2013 at 06:56.
> Pushed by harshkumar into branch 'master'.
> 
> Remaining Classes: Keys stored as constants
> 
> For classes - KateGlobalConfig, KateDocumentConfig & KateRendererConfig:
> Keys extracted & stored as constants.
> This improves maintainability.
> 
> This TODO is now resolved. So, removed the TODO comment.
> 
> REVIEW: 114000
> 
> M  +123  -75   part/utils/kateconfig.cpp


> +  const char * const KEY_TAB_WIDTH = "Tab Width";
> +  const char * const KEY_INDENTATION_WIDTH = "Indentation Width";
> +  const char * const KEY_INDENTATION_MODE = "Indentation Mode";
> +  const char * const KEY_TAB_HANDLING = "Tab Handling";
> +  const char * const KEY_WORD_WRAP = "Word Wrap";
> +  const char * const KEY_WORD_WRAP_AT = "Word Wrap Column";
> +  const char * const KEY_PAGEUP_DOWN_MOVES_CURSOR = "PageUp/PageDown Moves
> Cursor"; +  const char * const KEY_SMART_HOME = "Smart Home";
> +  const char * const KEY_SHOW_TABS = "Show Tabs";
> +  const char * const KEY_TAB_INDENTS = "Indent On Tab";
> +  const char * const KEY_KEEP_EXTRA_SPACES = "Keep Extra Spaces";
> +  const char * const KEY_INDENT_PASTED_TEXT = "Indent On Text Paste";
> +  const char * const KEY_BACKSPACE_INDENTS = "Indent On Backspace";
> +  const char * const KEY_SHOW_SPACES = "Show Spaces";
> +  const char * const KEY_REPLACE_TABS_DYN = "ReplaceTabsDyn";
> +  const char * const KEY_REMOVE_SPACES = "Remove Spaces";
> +  const char * const KEY_NEWLINE_AT_EOF = "Newline At EOF";
> +  const char * const KEY_OVR = "Overwrite Mode";
> +  const char * const KEY_ENCODING = "Encoding";
> +  const char * const KEY_EOL = "End of Line";
> +  const char * const KEY_ALLOW_EOL_DETECTION = "Allow End of Line
> Detection"; +  const char * const KEY_BOM = "BOM";
> +  const char * const KEY_ALLOW_SIMPLE_MODE = "Allow Simple Mode";
> +  const char * const KEY_BACKUP_FLAGS = "Backup Flags";
> +  const char * const KEY_SEARCH_DIR_CONFIG_DEPTH = "Search Dir Config
> Depth"; +  const char * const KEY_BACKUP_PREFIX = "Backup Prefix";
> +  const char * const KEY_BACKUP_SUFFIX = "Backup Suffix";
> +  const char * const KEY_SWAP_FILE_NO_SYNC = "No sync";
> +  const char * const KEY_ON_THE_FLY_SPELLCHECK = "On-The-Fly Spellcheck";
> +  const char * const KEY_LINE_LENGTH_LIMIT = "Line Length Limit";

can you make them "static const char *" ? :-)

Greetings,
Dominik
[prev in list] [next in list] [prev in thread] [next in thread]