[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevplatform/1.5] language/backgroundparser: Don't use WorstPriority in ParseProjectJob to make it
From:       Niko Sams <niko.sams () gmail ! com>
Date:       2013-01-21 17:15:16
Message-ID: 20130121171516.33266A6091 () git ! kde ! org
[Download RAW message or body]

Git commit 50841cc1baec67d997489736b9be16277c205b6e by Niko Sams.
Committed on 21/01/2013 at 19:13.
Pushed by nsams into branch '1.5'.

Don't use WorstPriority in ParseProjectJob to make it possible to create jobs with \
worse

Php needs to reschedule documents for parsing if unknown symbols are encountered. \
This is done by adding them to the background parser with a lower priority.

However this doesn't work on initial parsing when the project is opened as there all \
are added with WorstPriority - and so can't get added with worse priority.

This patch makes that possible by using another lower priority in ParseProjectJob.

REVIEW: 108527

M  +1    -0    language/backgroundparser/backgroundparser.h
M  +1    -1    language/backgroundparser/parseprojectjob.cpp

http://commits.kde.org/kdevplatform/50841cc1baec67d997489736b9be16277c205b6e

diff --git a/language/backgroundparser/backgroundparser.h \
b/language/backgroundparser/backgroundparser.h index 4c38d1a..ceb20a5 100644
--- a/language/backgroundparser/backgroundparser.h
+++ b/language/backgroundparser/backgroundparser.h
@@ -74,6 +74,7 @@ public:
         BestPriority = -10000,  ///Best possible job-priority. No jobs should \
                actually have this.
         NormalPriority = 0,     ///Standard job-priority. This priority is used for \
                parse-jobs caused by document-editing/opening.
                                 ///There is an additional parsing-thread reserved \
for jobs with this and better priority, to improve responsiveness. +        \
InitialParsePriority = 10000, ///Priority used when adding file on project loading  \
WorstPriority = 100000  ///Worst possible job-priority.  };
 
diff --git a/language/backgroundparser/parseprojectjob.cpp \
b/language/backgroundparser/parseprojectjob.cpp index 0f4cfcb..b0adc5e 100644
--- a/language/backgroundparser/parseprojectjob.cpp
+++ b/language/backgroundparser/parseprojectjob.cpp
@@ -87,7 +87,7 @@ void ParseProjectJob::start() {
     const int processAfter = 1000;
     int processed = 0;
     foreach(const IndexedString& url, files) {
-        ICore::self()->languageController()->backgroundParser()->addDocument( url, \
processingLevel, BackgroundParser::WorstPriority, this ); +        \
ICore::self()->languageController()->backgroundParser()->addDocument( url, \
processingLevel, BackgroundParser::InitialParsePriority, this );  ++processed;
         if (processed == processAfter) {
             QApplication::processEvents();


[prev in list] [next in list] [prev in thread] [next in thread]