[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [Konversation] 4584349: Even better fix for crash when watched nick
From:       Gary Cramblitt <garycramblitt () comcast ! net>
Date:       2010-07-01 13:27:46
Message-ID: 20100701132746.A4E26BB56BB () projects ! kde ! org
[Download RAW message or body]

commit 4584349844f6a8696dec8aceb2acf431da495981
Author: Gary Cramblitt <garycramblitt@comcast.net>
Date:   Tue Aug 3 01:00:29 2004 +0000

    Even better fix for crash when watched nick goes offline with USE_NICKINFO turned \
on.  Still a bug in here somewhere.  BTW, thanks JohnFlux  
    svn path=/trunk/kdeextragear-2/konversation/; revision=335373

diff --git a/konversation/server.cpp b/konversation/server.cpp
index e2321c2..c0e36a7 100644
--- a/konversation/server.cpp
+++ b/konversation/server.cpp
@@ -704,15 +704,14 @@ void Server::notifyResponse(const QString& nicksOnline)
       }
     }
     // Any watched nicks now offline?
-    NickInfoMap::Iterator it;
-    it = nicknamesOnline.begin();
+    NickInfoMap::Iterator it = nicknamesOnline.begin();
     while (it != nicknamesOnline.end())
     {
       QString lcNickName = it.key();
+      NickInfoPtr nickInfo = *it;
       ++it;
       if (nickLowerList.find(lcNickName) == nickLowerList.end())
       {
-        NickInfoPtr nickInfo = getNickInfo(lcNickName);
         QString nickName = nickInfo->getNickname();
         nicksOnlineChanged = true;
         addNickToOfflineList(nickName, watchLowerList);


[prev in list] [next in list] [prev in thread] [next in thread]