[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: koffice
From:       jaham () gmx ! net
Date:       2010-05-23 19:37:48
Message-ID: 201005232137.49064.jaham () gmx ! net
[Download RAW message or body]

On Saturday 22 May 2010 15:17:21 Thomas Zander wrote:
> SVN commit 1129452 by zander:
> 
> Make inheriting transformation an explicit property.
> 
> When the KoShapeContainer was introduced it had a 'clipped'
> property which implied two things;
>  * the shape is clipped to the outline of its parent container.
>  * the shape inherits the transformation of its parent container.
> 
> When I used a container, now 4 years later, I was confused why my
> shape didn't inherit the transformation and only by reading the code
> did I figure out thats because I designed it that way...
> Now it doesn't make sense to me anymore that one implies the other,
> the connection between them is a bit thin.
> So, split up the two properties and provide plenty of API docs on the
> matter.
> 
> Incidentally, this helps a usecase where I need the inherit concept
> but not the clipping concept ;)

It's great that after years flake gets a sane transformation handling where 
transformation are actually inherited without having to set an unrelated shape 
property. Is there actually still a usecase where the transformation should 
not be inherited?

Ciao Jan
[prev in list] [next in list] [prev in thread] [next in thread]