[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform/language/duchain/builders
From:       David Nolden <zwabel () googlemail ! com>
Date:       2009-07-22 17:41:11
Message-ID: 200907221941.11827.zwabel () googlemail ! com
[Download RAW message or body]

Am Mittwoch 22 Juli 2009 19:09:37 schrieb Milian Wolff:
> We used our own helper function which I could use to make the switch as
> painless as possible.
Then I suggest to just copy those 3 trivial functions plus the member away 
from AbstractDeclarationBuilder and change them back to QString. Actually I 
wouldn't have put that stuff there anyway, as it's an implementation detail.

> But your comment regarding performance is interesting: Should our parser
> also switch to use QByteArray instead of QString? Currently we store the
> file contents in a QString in our parse session.
>
> Maybe I should profile that...
It was not a big value, but a significant one for something that is not 
needed. Something like 3% with C++. So for php it most probably won't matter 
at all.

Greetings, David
[prev in list] [next in list] [prev in thread] [next in thread]