[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform/language/duchain/builders
From:       Milian Wolff <mail () milianw ! de>
Date:       2009-07-22 16:20:04
Message-ID: 4A673C34.4010703 () milianw ! de
[Download RAW message or body]

David Nolden wrote:
> SVN commit 1001129 by zwabel:
> 
> Use QByteArray instead of QString for storing the comment in \
> AbstractDeclarationBuilder. This makes utf8 special characters work correctly in \
> C++ comments. 
> 
> M  +3 -3      abstractdeclarationbuilder.h  
> 
> 
> --- trunk/KDE/kdevplatform/language/duchain/builders/abstractdeclarationbuilder.h \
> #1001128:1001129 @@ -47,9 +47,9 @@
> inline DeclarationType* currentDeclaration() const { return \
> m_declarationStack.isEmpty() ? 0 : \
> dynamic_cast<DeclarationType*>(m_declarationStack.top()); } 
> /// Access the current comment. \returns the current comment, or an empty string if \
>                 none exists.
> -  inline const QString& comment() const { return m_lastComment; }
> +  inline const QByteArray& comment() const { return m_lastComment; }
> /// Set the current \a comment. \param comment the new comment.
> -  inline void setComment(const QString& comment) { m_lastComment = comment; }
> +  inline void setComment(const QByteArray& comment) { m_lastComment = comment; }
> /// Clears the current comment.
> inline void clearComment() { m_lastComment.clear(); }
> 
> @@ -221,7 +221,7 @@
> 
> private:
> QStack<Declaration*> m_declarationStack;
> -  QString m_lastComment;
> +  QByteArray m_lastComment;
> };
> 
> }
> 


Oh man... now we have to change all the stuff in PHP?! It worked before, 
didn't it... Esp. with my commits which fixed Cpp... What is the 
advantage of storing it as QByteArray instead of QString?

-- 
Milian Wolff
http://milianw.de


[prev in list] [next in list] [prev in thread] [next in thread]