[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/plasma/applets/tasks
From:       Aaron J. Seigo <aseigo () kde ! org>
Date:       2009-07-07 20:07:39
Message-ID: 1246997259.953974.10277.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 992851 by aseigo:

clean up


 M  +8 -4      taskitemlayout.cpp  


--- trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskitemlayout.cpp \
#992850:992851 @@ -144,12 +144,13 @@
     int groupSize = 0;
 
     foreach (AbstractTaskItem *item, m_groupItem->members()) {
-        if (!item->abstractItem()) { //this item is a startup task
+        if (!item->abstractItem()) {
+            // this item is a startup task or the task no longer exists
             kDebug() << "Error, invalid item in groupMembers";
             continue;
         }
 
-        if (item->abstractItem() && item->abstractItem()->isGroupItem()) {
+        if (item->abstractItem()->isGroupItem()) {
             TaskGroupItem *group = static_cast<TaskGroupItem*>(item);
             if (!group->collapsed()) {
                 TaskItemLayout *layout = \
dynamic_cast<TaskItemLayout*>(group->tasksLayout()); @@ -157,11 +158,14 @@
                     kDebug() << "Error group has no layout";
                     continue;
                 }
-                groupSize += layout->size();// increase number of items since \
expanded groups occupy several spaces +
+                // increase number of items since expanded groups occupy several \
spaces +                groupSize += layout->size();
                 continue;
             }
         }
-        groupSize++;
+
+        ++groupSize;
     }
 
     //kDebug() << "group size" << groupSize;


[prev in list] [next in list] [prev in thread] [next in thread]