[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdevplatform/language/duchain/builders
From:       David Nolden <david.nolden.kde () art-master ! de>
Date:       2009-02-15 22:11:17
Message-ID: 1234735877.927685.12701.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 926653 by zwabel:

Add todos


 M  +2 -2      abstractusebuilder.h  


--- trunk/KDE/kdevplatform/language/duchain/builders/abstractusebuilder.h \
#926652:926653 @@ -88,7 +88,7 @@
 
     SimpleRange newRange = editorFindRange(name, name);
 
-    DUChainWriteLocker lock(DUChain::lock());
+    DUChainWriteLocker lock(DUChain::lock()); ///@todo Don't call findDeclarations \
                during write-lock, it can lead to UI lockups
     QList<Declaration*> declarations = \
LanguageSpecificUseBuilderBase::currentContext()->findDeclarations(id, \
newRange.start);  foreach (Declaration* declaration, declarations)
       if (!declaration->isForwardDeclaration()) {
@@ -123,7 +123,7 @@
   {
     DUChainWriteLocker lock(DUChain::lock());
 
-    bool encountered = false;
+    bool encountered = false; ///@todo This can cause I/O, so it would be better if \
                it was possible with only a read-lock
     int declarationIndex = \
LanguageSpecificUseBuilderBase::currentContext()->topContext()->indexForUsedDeclaration(declaration);
                
     int contextUpSteps = 0; //We've got to use the stack here, and not \
parentContext(), because the order may be different  


[prev in list] [next in list] [prev in thread] [next in thread]