[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: extragear/multimedia/amarok/src/browsers/filebrowser
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2009-01-03 17:48:13
Message-ID: e93871060901030948t1912a9adg8fd26e295d654b1e () mail ! gmail ! com
[Download RAW message or body]

On Sat, Jan 3, 2009 at 3:01 PM, Dominik Haumann <dhdev@gmx.de> wrote:
> On Thursday 25 December 2008, Mark Kretschmann wrote:
>> SVN commit 901488 by markey:
>>
>> Code cleanup.
>>
>> I hate this class. Can we please never import code from Kate again?
>> kthxbai
>>
>>  M  +31 -48    FileBrowser.cpp
>>  M  +5 -5      FileBrowser.h
>
> There are several classes which I really don't like as well. But that's no
> reason to talk about the whole Kate project in a bad way.
>
> Now if your commit message would instead say what this commit is about in
> more detail, it might even make sense to apply the changes to Kate's class
> as well.
>
> ...thanks for the efforts
> Dominik
>
> PS: now don't tell me you use Kate for development :p
> PPS: Drinking a beer with you if fine though ;)

I have to apologize, my wording was out of line here. The main problem
with the class is simply that your Kate coding style is very different
from Amarok's, so that it's hard for us to maintain the code.

Also it doesn't help that we forked it long ago from Kate. I assume
that the class has seen changes in Kate by now as well. It's simply a
case of code bit-rot that happens over the years.

Anyway, I was happy to see that you re-imported one of my patches, and
I'll be happy to work together closely with you on the remaining bugs
(e.g. https://bugs.kde.org/show_bug.cgi?id=157038).


PS: Sure we should have a beer sometime :)

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org
[prev in list] [next in list] [prev in thread] [next in thread]