[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: playground/base/plasma/applets/cia.vc
From:       Sebastian Kuegler <sebas () kde ! org>
Date:       2008-05-03 12:38:09
Message-ID: 200805031438.10485.sebas () kde ! org
[Download RAW message or body]


On Saturday 03 May 2008 08:34:40 Shawn Starr wrote:
> +void CiaVc::createConfigurationInterface(KConfigDialog *parent)
>   {
> +      Q_UNUSED(parent)
>         if (m_configDialog == 0) {

Why are you holding another dialog? createConfigurationInterface already gives 
you a pointer to a dialog, you should use that one. It also saves you 
creating a new one, keeping track of it,  and show()ing it.

Cheers,
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]