[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    KDE/kdebase/workspace/libs/plasma
From:       Frerich Raabe <raabe () kde ! org>
Date:       2007-11-22 20:30:24
Message-ID: 1195763424.880653.24144.nullmailer () svn ! kde ! org
[Download RAW message or body]

SVN commit 740217 by raabe:

- Don't leak memory; the "slot" string is allocated with qstrdup() with uses
  new[] internally.


 M  +2 -2      phase.cpp  


--- trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp #740216:740217
@@ -342,7 +342,7 @@
 {
     QMap<AnimId, CustomAnimationState*>::iterator it = d->customAnims.find(id);
     if (it != d->customAnims.end()) {
-        delete it.value()->slot;
+        delete [] it.value()->slot;
         delete it.value();
         d->customAnims.erase(it);
     }
@@ -540,7 +540,7 @@
             } else {
                 QMetaObject::invokeMethod(state->receiver, state->slot, Q_ARG(qreal, 1));
                 d->customAnims.erase(d->customAnims.find(state->id));
-                delete state->slot;
+                delete [] state->slot;
                 delete state;
             }
         } else {
[prev in list] [next in list] [prev in thread] [next in thread]