[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdelibs/kjs
From:       Luciano Montanaro <luciano.montanaro () consulenti ! fastweb ! it>
Date:       2007-06-20 15:33:35
Message-ID: 200706201733.35596.luciano.montanaro () consulenti ! fastweb ! it
[Download RAW message or body]

On mercoledì 20 giugno 2007, Maksim Orlovich wrote:
> >         * kjs/nodes.cpp:
> >         (VarDeclNode::evaluate): Additional check if the var decl
> > identifier is 'arguments'
>
> Ugh. I am pretty sure this stuff works right in KJS already (though
> probably by accident, due to optimizeForLocalAccess) --- do you have  a
> testcase showing it didn't work? If so, please add it to
> js/arguments-scope.js. And at any rate this is a hack on top of a hack.
> 'var foo;' should really have no effect during execution whatsoever.
> It's probably worth the effort to figure out why in the world we're doing
> this (for the global object, anyway), rather than piling on more hacks.

I just checked the original bug report:

http://bugs.webkit.org/show_bug.cgi?id=13456

The patch actually fixes this problem for the page in the bug report

( http://www.klm.com )

Follow the instructions in the bug report...

Anyway, I'll try to port the testcase from JSC testsuite.

Luciano




[prev in list] [next in list] [prev in thread] [next in thread]