[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: kdepim/korganizer
From:       Reinhold Kainhofer <reinhold () kainhofer ! com>
Date:       2005-03-24 19:43:12
Message-ID: 200503242043.17490.reinhold () kainhofer ! com
[Download RAW message or body]


Am Donnerstag, 24. März 2005 19:39 schrieb Bram Schoenmakers:
> CVS commit by bram:
>
> The structure of this code was messed up:
>
> o Make it compile now
> o todo->addAttachment(...) is placed in the beginChange() - endChange()
> block
>
>
>   M +8 -7      kotodoview.cpp   1.199
>
>
> --- kdepim/korganizer/kotodoview.cpp  #1.198:1.199
> @@ -256,5 +256,7 @@ void KOTodoListView::contentsDropEvent(
>        kdDebug(5850) << "Dropped : " << text << endl;
>        Todo*todo = todoi->todo();
> +      if( mChanger->beginChange( todo ) ) {
>        Todo*oldtodo = todo->clone();
> +
>        if( text.startsWith( "file:" ) ) {

Wouldn't it be simpler to use KURLDrag for dropping attachments instead of a 
QTextDrag and explicitly checking if the dropped text was a URL? This would 
allow it to also drop e.g. the current location of konqueror (the 
web-browser) and not only the location of konqueror (the file manager)....

Cheers,
Reinhold


-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna, Austria
email: reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at
 * K Desktop Environment, http://www.kde.org/, KOrganizer / KPilot maintainer

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]