[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdelibs/khtml/ecma
From:       David Faure <faure () kde ! org>
Date:       2004-10-11 22:50:26
Message-ID: 20041011225026.852E116BB5 () office ! kde ! org
[Download RAW message or body]

CVS commit by faure: 

Go back to getString() for namespaceURI, prefix and localName.
Mozilla and IE return null for those when not set - they are not html attributes, so \
they work differently. Testcase in khtmltests/regression/tests/dom/namespaces.html


  M +3 -3      kjs_dom.cpp   1.178


--- kdelibs/khtml/ecma/kjs_dom.cpp  #1.177:1.178
@@ -190,9 +190,9 @@ Value DOMNode::getValueProperty(ExecStat
     return getDOMNamedNodeMap(exec,node.attributes());
   case NamespaceURI:
-    return String(node.namespaceURI());
+    return getString(node.namespaceURI()); // Moz returns null if not set \
(dom/namespaces.html)  case Prefix:
-    return String(node.prefix());
+    return getString(node.prefix());  // Moz returns null if not set \
(dom/namespaces.html)  case LocalName:
-    return String(node.localName());
+    return getString(node.localName());  // Moz returns null if not set \
(dom/namespaces.html)  case OwnerDocument:
     return getDOMNode(exec,node.ownerDocument());


[prev in list] [next in list] [prev in thread] [next in thread]