[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdegames/ktuberling
From:       Andy Goossens <andygoossens () pandora ! be>
Date:       2004-02-09 18:29:48
Message-ID: 20040209182948.950329905 () office ! kde ! org
[Download RAW message or body]

CVS commit by goossens: 

getting rid of getenv("HOME")
(ugly, and not portable)

at first i wanted to replace this with QDir::homeDirPath()
but it seems most KDE apps use QString::null as the first argument with
KFileDialog::getSaveURL
(so i'm doing it here too for consistency)

makes sense to me, most users don't want to browse their entire disk to select
a specific dir each time they want to save something
might be a KDE styleguide issue for the usability team?


  M +2 -5      toplevel.cpp   1.62


--- kdegames/ktuberling/toplevel.cpp  #1.61:1.62
@@ -18,7 +18,4 @@
 #include <qclipboard.h>
 
-#include <stdlib.h>
-#include <unistd.h>
-
 #include "toplevel.moc"
 #include "playground.h"
@@ -327,5 +324,5 @@ void TopLevel::fileSave()
 {
   KURL url = KFileDialog::getSaveURL
-                (getenv("HOME"),
+                ( QString::null,
                  "*.tuberling");
 
@@ -360,5 +357,5 @@ void TopLevel::filePicture()
 
   KURL url = KFileDialog::getSaveURL
-                (getenv("HOME"),
+                ( QString::null,
                  i18n(  "*.xpm|UNIX pixmaps (*.xpm)\n"
                         "*.jpg|JPEG compressed files (*.jpg)\n"


[prev in list] [next in list] [prev in thread] [next in thread]