[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    kdebase/kcontrol/konqhtml
From:       Dirk Mueller <mueller () kde ! org>
Date:       2003-10-04 19:03:16
[Download RAW message or body]

CVS commit by mueller: 

make the use of the JS debugger configurable, default to off.


  M +8 -1      jsopts.cpp   1.47
  M +1 -0      jsopts.h   1.14


--- kdebase/kcontrol/konqhtml/jsopts.cpp  #1.46:1.47
@@ -43,5 +43,5 @@ KJavaScriptOptions::KJavaScriptOptions( 
 
   // the global checkbox
-  QVGroupBox* globalGB = new QVGroupBox( i18n( "Global Settings" ), this );
+  QGroupBox* globalGB = new QGroupBox( 2, Vertical, i18n( "Global Settings" ), this );
   toplevel->addWidget( globalGB );
 
@@ -58,4 +58,8 @@ KJavaScriptOptions::KJavaScriptOptions( 
   connect( reportErrorsCB, SIGNAL( clicked() ), this, SLOT( slotChanged() ) );
 
+  jsDebugWindow = new QCheckBox( i18n( "Enable debu&gger" ), globalGB );
+  QWhatsThis::add( jsDebugWindow, i18n( "Enables builtin JavaScript debugger." ) );
+  connect( jsDebugWindow, SIGNAL( clicked() ), SLOT( slotChanged() ) );
+
   // the domain-specific listview
   domainSpecific = new JSDomainListView(m_pConfig,m_groupname,this);
@@ -118,4 +122,5 @@ void KJavaScriptOptions::load()
                 js_global_policies.isFeatureEnabled());
     reportErrorsCB->setChecked( m_pConfig->readBoolEntry("ReportJavaScriptErrors",false));
+    jsDebugWindow->setChecked( m_pConfig->readBoolEntry( "EnableJavaScriptDebug",false ) );
 //    js_popup->setButton( m_pConfig->readUnsignedNumEntry("WindowOpenPolicy", 0) );
     setChanged(false);
@@ -128,4 +133,5 @@ void KJavaScriptOptions::defaults()
                 js_global_policies.isFeatureEnabled());
   reportErrorsCB->setChecked( false );
+  jsDebugWindow->setChecked( false );
   setChanged(true);
 }
@@ -135,4 +141,5 @@ void KJavaScriptOptions::save()
     m_pConfig->setGroup(m_groupname);
     m_pConfig->writeEntry( "ReportJavaScriptErrors", reportErrorsCB->isChecked() );
+    m_pConfig->writeEntry( "EnableJavaScriptDebug", jsDebugWindow->isChecked() );
 
     domainSpecific->save(m_groupname,"ECMADomains");

--- kdebase/kcontrol/konqhtml/jsopts.h  #1.13:1.14
@@ -75,4 +75,5 @@ private:
   QCheckBox *enableJavaScriptGloballyCB;
   QCheckBox *reportErrorsCB;
+  QCheckBox *jsDebugWindow;
   JSPoliciesFrame *js_policies_frame;
   bool _removeECMADomainSettings;


[prev in list] [next in list] [prev in thread] [next in thread]