[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: [Reminder] KDE 4.1 Beta 2
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2008-06-16 22:38:07
Message-ID: 200806170038.07919.neundorf () kde ! org
[Download RAW message or body]

On Tuesday 17 June 2008, Sune Vuorela wrote:
> On 2008-06-16, Alexander Neundorf <neundorf@kde.org> wrote:
> > On Monday 16 June 2008, Sune Vuorela wrote:
> > ...
> >
> >> It fits svn r819867  currently, as uploaded over the weekend to
> >> debian/experimental and still seems to work.
> >
> > Hmm ?
> > When I remember correctly your patches still had the EXPORT-stuff, which
> > I would strongly suggest not to use before KDE 4.2.
> > Sorry to ask again, but could you please post again which patches you are
> > currently using ?

I'd strongly suggest not to use patch 97, because
-it will behave somewhat different than KDE svn
-it is not really necessary

> For kdelibs it is:
> http://svn.debian.org/wsvn/pkg-kde/branches/kde4/packages/kdelibs/debian/pa
>tches/97_use_imported_targets_with_cmake26.diff?op=file&rev=0&sc=0


Patch 98:
In some places it contains stuff like:

set_target_properties(${KJSLIBNAME} PROPERTIES LINK_INTERFACE_LIBRARIES "")

This is not necessary, if that option is enabled, LINK_INTERFACE_LIBRARIES is 
by default set to empty now.

Why are the LINK_INTERFACE_LIBRARIES split into patches 98 and 99 ?

> On top of this, explicitly add the stuff that are used:
> http://svn.debian.org/wsvn/pkg-kde/branches/kde4/packages/kdelibs/debian/pa
>tches/98_link_interface_libraries.diff?op=file&rev=0&sc=0
>
>
> and setting some link interface libraries - this one might need to be
> reviewed a bit, but basically it works.
> http://svn.debian.org/wsvn/pkg-kde/branches/kde4/packages/kdelibs/debian/pa
>tches/99_more_implicit_link_libs.diff?op=file&rev=0&sc=0

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]