[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gtk-devel
Subject:    Re: Call not guarded properly
From:       Matthias Clasen <matthias.clasen () gmail ! com>
Date:       2017-06-02 15:09:50
Message-ID: CAFwd_vDRgPuVvn1RcsfzNw79r5HQc+DmJwAZPmUKrPr_cOdc1w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks for pointing thus out, I'll have a look

On Jun 2, 2017 07:03, "John Emmas via gtk-devel-list" <
gtk-devel-list@gnome.org> wrote:

After updating glib from git master today I can no longer build with MSVC.
The build now fails to link because gio makes a call to
'g_openuri_portal_open_uri_finish()' (in function
'g_app_info_launch_default_for_uri_finish()')

Looking around at similar calls, I reckon the function should maybe look
like this:-

    gboolean
    g_app_info_launch_default_for_uri_finish (GAsyncResult  *result,

                GError       **error)
    {
    #ifdef G_OS_UNIX  // <--- This guard added by me !!!!
      return g_openuri_portal_open_uri_finish (result, error);
    #endif
      return FALSE;  // <--- and this added by me !!!!
    }

Should I flag this up in bugzilla or have I misunderstood something?

John

_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

[Attachment #5 (text/html)]

<div dir="auto">Thanks for pointing thus out, I&#39;ll have a look</div><div \
class="gmail_extra"><br><div class="gmail_quote">On Jun 2, 2017 07:03, &quot;John \
Emmas via gtk-devel-list&quot; &lt;<a \
href="mailto:gtk-devel-list@gnome.org">gtk-devel-list@gnome.org</a>&gt; wrote:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <font face="Calibri">After updating glib from git master today I can
      no longer build with MSVC.   The build now fails to link because
      gio makes a call to </font><font \
                face="Calibri">&#39;g_openuri_portal_open_uri_<wbr>finish()&#39;
      (in function &#39;g_app_info_launch_default_<wbr>for_uri_finish()&#39;)<br>
      <br>
      Looking around at similar calls, I reckon the function should
      maybe look like this:-<br>
      <br>
             gboolean<br>
             g_app_info_launch_default_for_<wbr>uri_finish (GAsyncResult  
      *result,<br>
                                                                                      \
  GError             **error)<br>
             {<br>
             #ifdef G_OS_UNIX   // &lt;--- This guard added by me !!!!<br>
               return g_openuri_portal_open_uri_<wbr>finish (result, error);<br>
             #endif<br>
               return FALSE;   // &lt;--- and this added by me !!!!<br>
             }<br>
      <br>
      Should I flag this up in bugzilla or have I misunderstood
      something?<font color="#888888"><br>
      <br>
      John<br>
    </font></font>
  </div>

<br>______________________________<wbr>_________________<br>
gtk-devel-list mailing list<br>
<a href="mailto:gtk-devel-list@gnome.org">gtk-devel-list@gnome.org</a><br>
<a href="https://mail.gnome.org/mailman/listinfo/gtk-devel-list" rel="noreferrer" \
target="_blank">https://mail.gnome.org/<wbr>mailman/listinfo/gtk-devel-<wbr>list</a><br>
 <br></blockquote></div><br></div>



_______________________________________________
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list


[prev in list] [next in list] [prev in thread] [next in thread]